Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show loading-indicator while Project is uploading #78

Closed
TonySpegel opened this issue Oct 21, 2019 · 6 comments
Closed

Show loading-indicator while Project is uploading #78

TonySpegel opened this issue Oct 21, 2019 · 6 comments

Comments

@TonySpegel
Copy link

Pretty much the title,

I was wondering if my CLI was frozen or something but nope, it just may take a while to upload everything. And for this case it'd be neat to have a loading-indicator of some kind.
Otherwise it's just ES5 bundle generation complete. and then after quite some time:
🚀 Successfully published via angular-cli-ghpages! Have a nice day!
Somewhere in between these two would be nice :)

And thank you for your great work

@fmalcher
Copy link
Member

Thanks for the suggestion! If we do so, it should have an opt-out via a "progress=false" or "no-progress" flag. Otherwise it would pollute CI logs.

@JohannesHoppe
Copy link
Member

JohannesHoppe commented Oct 22, 2019

That's a nice idea. It would be difficulty to figure out the real progress, because the upload is done via git executable and we would need to grab somehow the output from there.

@TonySpegel Is it fine for you too if it just prints: Uploading via git, please wait... ?!
@fmalcher Logs are already polluted because of the progress of the build. Our circle logs are very long because of that... 🙄

@fmalcher
Copy link
Member

@JohannesHoppe There should be a --no-progress option in angular-cli-ghpages that forwards to the build process!

@TonySpegel
Copy link
Author

@JohannesHoppe of course, that would be sufficient =)

@JohannesHoppe
Copy link
Member

I added the text:

👨‍🚀 Uploading via git, please wait...

@TonySpegel
Copy link
Author

Thank you for adding this feature 😸 great job :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants