Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 16 support #167

Closed
fmalcher opened this issue May 3, 2023 · 1 comment · May be fixed by jcharra/bee-notes#38, jcharra/bee-notes#39, jcharra/bee-notes#40 or jcharra/bee-notes#41
Closed

Angular 16 support #167

fmalcher opened this issue May 3, 2023 · 1 comment · May be fixed by jcharra/bee-notes#38, jcharra/bee-notes#39, jcharra/bee-notes#40 or jcharra/bee-notes#41

Comments

@fmalcher
Copy link
Member

fmalcher commented May 3, 2023

Angular 16 is out, and we are happy to say that this package is compatible with the new Angular without any notable changes.
However, the ng add command fails at the moment:

$ ng add angular-cli-ghpages
ℹ Using package manager: npm
✔ Found compatible package version: [email protected].
✔ Package information loaded.

The package [email protected] will be installed and executed.
Would you like to proceed? Yes
✔ Packages successfully installed.
NOT SUPPORTED: keyword "id", use "$id" for schema ID

This is because the Angular CLI looks for the most compatible version where all peerDependencies are met.
Since we set Angular itself to <= 15 in our peer deps, it will select a very old version.

As a workaround, please add @latest here and ignore the warning:

ng add angular-cli-ghpages@latest

This is a very small fix, and we're trying to release a new version in the next couple of days.
PRs are welcome!

@fmalcher fmalcher pinned this issue May 3, 2023
@JohannesHoppe
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment