Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close "Add Task" from when task saved #181

Closed
angrykoala opened this issue Oct 10, 2017 · 15 comments
Closed

Close "Add Task" from when task saved #181

angrykoala opened this issue Oct 10, 2017 · 15 comments
Milestone

Comments

@angrykoala
Copy link
Owner

Saving a new task will leave the "Add Task" form open to add a new task. This behavior is a bit inconsistent. Is better to completely close the form, the same way it works when editing a task

@cedric-h
Copy link

I'll try this out.

@cedric-h
Copy link

It's going to take me 8+ hours to get back to this, if someone else wants to do it in that time, that's fine by me

@panvourtsis
Copy link
Contributor

i could do it if you want

@angrykoala
Copy link
Owner Author

angrykoala commented Oct 10, 2017

Aren't you already working on 2 or 3 other issues @panvourtsis ?

@panvourtsis
Copy link
Contributor

panvourtsis commented Oct 10, 2017

only task ordering which is very close to this. #156
I will leave for the @DefecateRainbows no problem

@angrykoala
Copy link
Owner Author

angrykoala commented Oct 10, 2017

If I remember correctly, you also offered to do #161
I mean, you can work on whatever you want, and it's ok by me if you want to do this issue, but if you are going to take a break from an issue (to work on another thing or simply because of lack of time) send a message so other people are aware that they can work on that thing.

Mainly to avoid blockings or people working on the same thing 😄

@panvourtsis
Copy link
Contributor

Yeah we discussed #161 but i didn't know you expected i'll do it. Go confused there!
I will though thanks for clarifying ;)

@angrykoala
Copy link
Owner Author

Oh, sorry, I misunderstood about #161 .

@cedric-h
Copy link

Alright, I'm on this.

@cedric-h
Copy link

Alright, I'm having much more trouble than I should with this. Someone else is going to have to do this D:

@ssteuteville
Copy link
Contributor

ssteuteville commented Oct 11, 2017

I'll try tonight. Hacktoberfest

@ssteuteville
Copy link
Contributor

hmmmm.. I have this implemented but I can't get the tests running on Windows 10. Any advice?

`$ npm test

[email protected] test C:\Users\ssteu\dev\gaucho
npm run clean && istanbul cover _mocha && npm run jshint

[email protected] clean C:\Users\ssteu\dev\gaucho
rm -rf builds config.json tasks.json coverage

No coverage information was collected, exit without writing coverage information
C:\Users\ssteu\dev\gaucho\node_modules.bin_mocha.CMD:1
(function (exports, require, module, __filename, __dirname) { @if EXIST "%~dp0\node.exe" (
^
SyntaxError: Invalid or unexpected token
at createScript (vm.js:56:10)
at Object.runInThisContext (vm.js:97:10)
at Module._compile (module.js:542:28)
at Object.Module._extensions..js (module.js:579:10)
at Object.Module._extensions.(anonymous function) [as .js] (C:\Users\ssteu\dev\gaucho\node_modules\istanbul\lib\hook.js:109:37)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
at Function.Module.runMain (module.js:604:10)
at runFn (C:\Users\ssteu\dev\gaucho\node_modules\istanbul\lib\command\common\run-with-cover.js:122:16)
npm ERR! Test failed. See above for more details.`

@angrykoala
Copy link
Owner Author

@ssteuteville Try to execute just mocha

Please, tell me the result of node -v as well

@ssteuteville
Copy link
Contributor

I got it working with the command listed in this issue. gotwarlost/istanbul#90

node -v v6.11.1

@angrykoala
Copy link
Owner Author

I'll add this problem to a page in the wiki, in case someone else has this issue with the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants