Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align with pyvex on max_instructions behavior #85

Open
mborgerson opened this issue Dec 1, 2023 · 0 comments
Open

Align with pyvex on max_instructions behavior #85

mborgerson opened this issue Dec 1, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@mborgerson
Copy link
Member

mborgerson commented Dec 1, 2023 •
edited
Loading

Description

If max_instructions=1 when pyvex lifts an instruction that will cause delay slot execution, it will return NoDecode. pypcode will actually return 2 instructions. Probably best to be consistent with pyvex here and always decode at most max_instructions, including delay slot execution.

Steps to reproduce the bug

No response

Environment

No response

Additional context

No response
@mborgerson mborgerson added the bug Something isn't working label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mborgerson