Dependency "Generic and Extensible Text Editor" version too high?

[ddekany]

It's maybe just a cosmetical issue, but apparently you are working with a higher version of said bundle that what's possible on Photon M6. So the user gets a warning when installing the plugin, and then he uses the plugin with not the exact same dependency version as you do.

Cannot perform operation. Computing alternate solutions, may take a while: x/15

and then

Your original request has been modified.
  "Generic and Extensible Text Editor" is already installed, so an update will be performed instead.
Cannot complete the install because of a conflicting dependency.
  Software being installed: Generic and Extensible Text Editor 1.1.0.v20180316-0841 (org.eclipse.ui.genericeditor 1.1.0.v20180316-0841)
  Software currently installed: Eclipse IDE for Java EE Developers 4.8.0.20180315-1215 (epp.package.jee 4.8.0.20180315-1215)
  Only one of the following can be installed at once: 
    Generic and Extensible Text Editor 1.1.0.v20171212-0901 (org.eclipse.ui.genericeditor 1.1.0.v20171212-0901)
    Generic and Extensible Text Editor 1.1.0.v20180228-1652 (org.eclipse.ui.genericeditor 1.1.0.v20180228-1652)
    Generic and Extensible Text Editor 1.1.0.v20180316-0841 (org.eclipse.ui.genericeditor 1.1.0.v20180316-0841)
    Generic and Extensible Text Editor 1.1.0.v20171204-0941 (org.eclipse.ui.genericeditor 1.1.0.v20171204-0941)
  Cannot satisfy dependency:
    From: Eclipse IDE for Java EE Developers 4.8.0.20180315-1215 (epp.package.jee 4.8.0.20180315-1215)
    To: org.eclipse.equinox.p2.iu; org.eclipse.platform.feature.group [4.8.0.v20180308-0630,4.8.0.v20180308-0630]
  Cannot satisfy dependency:
    From: Eclipse Platform 4.8.0.v20180308-0630 (org.eclipse.platform.feature.group 4.8.0.v20180308-0630)
    To: org.eclipse.equinox.p2.iu; org.eclipse.ui.genericeditor [1.1.0.v20180228-1652,1.1.0.v20180228-1652]

[angelozerr]

I think we could remove generic editor dependency to install since it exists since oxygen.

[ddekany]

I guess so, as far as it's still declared as a required dependency... but I really don't know Eclipse platform best practices.

[angelozerr]

I guess so, as far as it's still declared as a required dependency... but I really don't know Eclipse platform best practices.

Indeed it's required because it's the genereic editor which opens the ftl editor (there is no specific FreemarkerEditor).

I mean that Oxygen and Photon provides this GenerecEditor, so we don't need to provide it in the installation as Dependency.

[ddekany]

I know it's required, what I said is just that maybe you can just declare that the bundle it's required, and not include the jar in the plugin... Well, we are saying the same, I guess.

[angelozerr]

Well, we are saying the same, I guess.

yes I think:)