Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sass-loader #164

Closed
bkonkle opened this issue Jun 5, 2017 · 1 comment
Closed

Update sass-loader #164

bkonkle opened this issue Jun 5, 2017 · 1 comment

Comments

@bkonkle
Copy link

bkonkle commented Jun 5, 2017

Looks like we need to bump node-sass to support Node 8: sass/node-sass#1984

I tried to test out the change, but I don't see anywhere that node-sass is actually being used. Is it there just because of the peer dependency in sass-loader?

In any case, for Node 8 support we'll need to bump them to the latest versions. :-)
@andywer
Copy link
Owner

andywer commented Jun 6, 2017

Thanks for pointing out, @bkonkle!

Yes, I think node-sass was a peer dependency of the sass-loader. Will create a PR.

@andywer andywer mentioned this issue Jun 6, 2017
Merged
@andywer andywer mentioned this issue Jun 6, 2017
Merged
@andywer andywer changed the title Remove node-sass from dependencies, update sass-loader Update sass-loader Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bkonkle @andywer