Add options to Form#valid? to allow skipping of nested and array forms

Author: andypike

Diff for: Gemfile.lock

@@ -8,7 +8,7 @@ GIT
 PATH
   remote: .
   specs:
-    rectify (0.9.1)
+    rectify (0.10.0)
       activemodel (>= 4.1.0)
       activerecord (>= 4.1.0)
       activesupport (>= 4.1.0)
@@ -45,6 +45,7 @@ GEM
       thread_safe (~> 0.3, >= 0.3.4)
       tzinfo (~> 1.1)
     arel (6.0.3)
+    ast (2.2.0)
     awesome_print (1.6.1)
     axiom-types (0.1.1)
       descendants_tracker (~> 0.0.4)
@@ -69,6 +70,9 @@ GEM
     minitest (5.8.4)
     nokogiri (1.6.7.2)
       mini_portile2 (~> 2.0.0.rc2)
+    parser (2.3.0.6)
+      ast (~> 2.2)
+    powerpack (0.1.1)
     pry (0.10.3)
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)
@@ -84,6 +88,7 @@ GEM
       rails-deprecated_sanitizer (>= 1.0.1)
     rails-html-sanitizer (1.0.3)
       loofah (~> 2.0)
+    rainbow (2.1.0)
     rake (11.1.2)
     rspec (3.4.0)
       rspec-core (~> 3.4.0)
@@ -100,11 +105,19 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.4.0)
     rspec-support (3.4.1)
+    rubocop (0.37.2)
+      parser (>= 2.3.0.4, < 3.0)
+      powerpack (~> 0.1)
+      rainbow (>= 1.99.1, < 3.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (~> 0.3)
+    ruby-progressbar (1.7.5)
     slop (3.6.0)
     sqlite3 (1.3.11)
     thread_safe (0.3.5)
     tzinfo (1.2.2)
       thread_safe (~> 0.1)
+    unicode-display_width (0.3.1)
     virtus (1.0.5)
       axiom-types (~> 0.1)
       coercible (~> 1.0)
@@ -123,6 +136,7 @@ DEPENDENCIES
   rectify!
   rspec (~> 3.4)
   rspec-collection_matchers (~> 1.1)
+  rubocop
   sqlite3
   wisper-rspec!
 

Diff for: lib/rectify/form.rb

@@ -58,10 +58,21 @@ def persisted?
       id.present? && id.to_i > 0
     end
 
-    def valid?(context = nil)
+    def valid?(options = {})
       before_validation
 
-      [super, form_attributes_valid?, arrays_attributes_valid?].all?
+      options     = {} if options.blank?
+      context     = options[:context]
+      validations = [super(context)]
+
+      validations << form_attributes_valid? unless options[:exclude_nested]
+      validations << array_attributes_valid? unless options[:exclude_arrays]
+
+      validations.all?
+    end
+
+    def invalid?(options = {})
+      !valid?(options)
     end
 
     def to_key
@@ -119,7 +130,7 @@ def form_attributes_valid?
         .all?
     end
 
-    def arrays_attributes_valid?
+    def array_attributes_valid?
       array_attributes_that_respond_to(:valid?)
         .map(&:valid?)
         .all?

Diff for: lib/rectify/version.rb

@@ -1,3 +1,3 @@
 module Rectify
-  VERSION = "0.9.1".freeze
+  VERSION = "0.10.0".freeze
 end

Diff for: readme.md

@@ -371,6 +371,43 @@ your form as well as any (deeply) nested form objects and array attributes that
 contain form objects. There is also an `#invalid?` method that returns the
 opposite of `#valid?`.
 
+The `#valid?` and `#invalid?` methods also take a set of options. These options allow
+you to not validate nested form objects or array attributes that contain form objects.
+For example:
+
+```ruby
+class UserForm < Rectify::Form
+  attribute :name,     String
+  attribute :address,  AddressForm
+  attribute :contacts, Array[ContactForm]
+
+  validates :name, :presence => true
+end
+
+class AddressForm < Rectify::Form
+  attribute :street,    String
+  attribute :town,      String
+  attribute :city,      String
+  attribute :post_code, String
+
+  validates :street, :post_code, :presence => true
+end
+
+class ContactForm < Rectify::Form
+  attribute :name,   String
+  attribute :number, String
+
+  validates :name, :presence => true
+end
+
+form = UserForm.from_params(params)
+
+form.valid?(:exclude_nested => true, :exclude_arrays => true)
+```
+
+In this case, the `UserForm` attributes will be validated (`name` in the example above)
+but the `address` and `contacts` will not be validated.
+
 ### Deep Context
 
 It's sometimes useful to have some context within your form objects when performing
@@ -1054,11 +1091,11 @@ application. Something like the following:
 └── app
     ├── controllers
     ├── core
-    │   ├── billing
-    │   ├── fulfillment
-    │   ├── ordering
-    │   ├── reporting
-    │   └── security
+    │   ├── billing
+    │   ├── fulfillment
+    │   ├── ordering
+    │   ├── reporting
+    │   └── security
     ├── models
     └── views
 ```

Diff for: rectify.gemspec

@@ -25,4 +25,5 @@ Gem::Specification.new do |s|
   s.add_development_dependency "rspec-collection_matchers", "~> 1.1"
   s.add_development_dependency "sqlite3"
   s.add_development_dependency "rake"
+  s.add_development_dependency "rubocop"
 end

Diff for: spec/lib/rectify/form_spec.rb

@@ -418,6 +418,14 @@
           expect(form.head).not_to be_valid
         end
       end
+
+      context "when ignoring nested forms with invalid values" do
+        it "returns true" do
+          form = SchoolForm.new(:head => TeacherForm.new(:name => ""))
+
+          expect(form).to be_valid(:exclude_nested => true)
+        end
+      end
     end
 
     describe "validating array attributes containing forms" do
@@ -435,12 +443,26 @@
 
       context "when the array of forms has invalid values" do
         it "returns false" do
-          form = UserForm.new(:contacts => [ContactForm.new(:name => "")])
+          form = UserForm.new(
+            :first_name => "Andy",
+            :contacts => [ContactForm.new(:name => "")]
+          )
 
           expect(form).not_to be_valid
           expect(form.contacts.first).not_to be_valid
         end
       end
+
+      context "when ignoring narray of forms with invalid values" do
+        it "returns true" do
+          form = UserForm.new(
+            :first_name => "Andy",
+            :contacts => [ContactForm.new(:name => "")]
+          )
+
+          expect(form).to be_valid(:exclude_arrays => true)
+        end
+      end
     end
   end