All Tasks and Calendar Events from some calendars show grey after update to ToDoAgenda 4.5.3

[jimfum]

Calendar events are correctly in white text color as before but Task.org events are in grey. Cannot find settings that would allow me to control that. Was fine (all white) before 4.5.3.

[yvolk]

Hi @jimfum , I think this change is caused by "Implement strikethrough and partial transparency for event status", please see #82
Please try to change status... in that events.

[jimfum]

Hi @yvolk. I've checked the refered ticket but don't see what I could do. You're suggesting it's because the event is tentative, right? That confuses me, because the tasks are just for me and I don't see anything about making them 'accepted' automatically.

[yvolk]

@feilen Could you help with the issue in your change, please.
...Anyway, looks like we will need a new setting to disable this "strikethrough and partial transparency for event status" feature...

[JanHellwig]

Hi.
I've run into the same issue as @jimfum on some of my calendars. It seems to indeed be related to the status of the events, but I can't even find an option to change that in my calendar app.

Having an option to either disable the transparency for status would be much appreciated as the widget currently looks pretty broken for me. Alternatively it might also be an idea to just expose the color for tentative events in the settings in the same way you can configure past events to have a different color that future ones?

[yvolk]

I've run into the same issue as @jimfum on some of my calendars.

@JanHellwig It's interesting, what is special in those calendars, how do think?
And could you send me (or post here) some (filtered out for privacy or created specifically for testing) "Share events and settings for debugging" as described in #71 in order for me to understand, why some events are interpreted as tentative, and some are not.

[zelleb]

I sync my calendars with my nextcloud. The automatically created contact birthdays calendar events are all greyed out. They are created with a reminder at midnight. Hope that helps.

[pbarbiero]

I have the same issue -- any events now (from exchange) that in my google calendar have the 'outline' instead of the solid fill, show faded in the todo agenda and I have no option to change this back to how it was before.

[yvolk]

@pbarbiero Could you send me (or post here) some (filtered out for privacy or created specifically for testing) "Share events and settings for debugging" as described in #71 so I could see actual data that our widget receives.

[pbarbiero]

Let me know if you want more or anything else -- this is one event and my settings that exhibits the issue.

{
  "deviceInfo": {
    "versionCode": 27,
    "versionRelease": "8.1.0",
    "versionCodename": "REL",
    "buildManufacturer": "OnePlus",
    "buildBrand": "OnePlus",
    "buildModel": "ONEPLUS A5010"
  },
  "applicationInfo": {
    "versionName": "4.5.3",
    "versionCode": 695
  },
  "settings": {
    "widgetId": 37,
    "widgetHeaderDateFormat": "hidden:",
    "widgetInstanceName": "Todo Agenda 37",
    "activeSources": [...],    
	"eventRange": 30,
    "eventsEnded": "TODAY",
    "fillAllDay": true,
    "hideBasedOnKeywords": "",
    "widgetHeaderBackgroundColor": 0,
    "pastEventsBackgroundColor": -1543503872,
    "todaysEventsBackgroundColor": -2147483648,
    "backgroundColor": -2147483648,
    "textColorSource": "shading",
    "headerTheme": "DARK",
    "widgetHeaderTextColor": -1694498817,
    "dayHeaderThemePast": "DARK",
    "dayHeaderTextColorPast": -3355444,
    "entryThemePast": "BLACK",
    "eventTextColorPast": -1,
    "dayHeaderTheme": "DARK",
    "dayHeaderTextColorToday": -8947849,
    "entryTheme": "BLACK",
    "eventTextColorToday": -16777216,
    "dayHeaderThemeFuture": "DARK",
    "dayHeaderTextColorFuture": -3355444,
    "entryThemeFuture": "BLACK",
    "eventTextColorFuture": -1,
    "showDaysWithoutEvents": true,
    "showDayHeaders": true,
    "dayHeaderDateFormat": "defaultWeekday:",
    "horizontalLineBelowDayHeader": true,
    "showPastEventsUnderOneHeader": false,
    "showPastEventsWithDefaultColor": false,
    "showEventIcon": true,
    "entryDateFormat": "hidden:",
    "showEndTime": true,
    "showLocation": true,
    "dateFormat": "auto",
    "lockedTimeZoneId": "",
    "snapshotMode": "live_data",
    "refreshPeriodMinutes": 10,
    "eventEntryLayout": "DEFAULT",
    "multiline_title": true,
    "multiline_details": false,
    "showOnlyClosestInstanceOfRecurringEvent": false,
    "hideDuplicates": false,
    "allDayEventsPlacement": "top_day",
    "taskScheduling": "date_due",
    "taskWithoutDates": "end_of_list",
    "filterMode": "normal",
    "indicateAlerts": false,
    "indicateRecurring": false,
    "compactLayout": false,
    "widgetHeaderLayout": "HIDDEN",
    "textSizeScale": "0.8",
    "dayHeaderAlignment": "LEFT"
  },
  "resultsVersion": 3,
  "results": [
   {
      "providerType": 1,
      "executedAt": 1647452218111,
      "timeZoneId": "America\/New_York",
      "millisOffsetUtcToLocal": -14400000,
      "standardMillisOffsetUtcToLocal": -18000000,
      "uri": "content:\/\/com.android.calendar\/instances\/when\/x\/y",
      "projection": [
        "calendar_id",
        "event_id",
        "eventStatus",
        "title",
        "begin",
        "end",
        "allDay",
        "eventLocation",
        "hasAlarm",
        "rrule",
        "displayColor",
        "calendar_color"
      ],
      "selection": "selfAttendeeStatus!=2 AND (calendar_id = 2 OR calendar_id = 3 OR calendar_id = 4 OR calendar_id = 5 )",
      "selectionArgs": [],
      "sortOrder": "startDay ASC, allDay DESC, begin ASC ",
      "rows": [
        {
          "allDay": {
            "type": 1,
            "value": 0
          },
          "rrule": {
            "type": 3,
            "value": "FREQ=WEEKLY;INTERVAL=1;BYDAY=MO;UNTIL=20221231T143500Z"
          },
          "event_id": {
            "type": 1,
            "value": 1277
          },
          "calendar_id": {
            "type": 1,
            "value": 4
          },
          "eventLocation": {
            "type": 3,
            "value": "x"
          },
          "end": {
            "type": 1,
            "value": 1647266700000
          },
          "displayColor": {
            "type": 1,
            "value": -883456
          },
          "title": {
            "type": 3,
            "value": "Title"
          },
          "begin": {
            "type": 1,
            "value": 1647264900000
          },
          "hasAlarm": {
            "type": 1,
            "value": 1
          },
          "calendar_color": {
            "type": 1,
            "value": -883456
          }
        },

[feilen]

Whoops, yeah in hindsight a toggle would have been a good idea. IIRC 'Tentative' is 0, so if the api doesnt populate it we probably get that back.
Being able to do it on a per-calendar basis would be ideal, but a global 'Off' 'Show Cancelled' 'Show Canceled/Tentative' would be best. I'll try to find some time to look into it

[yvolk]

Thank you all!
Turning all tasks grey was really a bug that we didn't notice.
As a quick fix I also disabled the "transparency for tentative tasks/events" feature. If needed, we will add it as a separate color setting as suggested above.
Please test v.4.5.4 here #3

Thank you, @feilen, please check my fix.

[feilen]

You're quick! And yeah that should be plenty.

I might look into the per-calendar approach first then... Usefulness is questionable if you end up with even just one calendar thats got garbage data, one way or another.

[yvolk]

I published the fixed v.4.5.4 for F-Droid and to Google Play. It's also available immediately here: #3

[yvolk]

You're quick!

@feilen That's because I got several emails in addition to posts here. And realized that the problem affects many users.
BTW, according to Google Play there are more than 10 thousand of ToDo Agenda's users who updated their apps in Google Play recently. Probably even more in F-Droid.