Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events showing incorrect time after DST changeover #83

Closed
cas-- opened this issue Nov 4, 2021 · 6 comments
Closed

Events showing incorrect time after DST changeover #83

cas-- opened this issue Nov 4, 2021 · 6 comments

Comments

@cas--
Copy link

cas-- commented Nov 4, 2021

I think I have found a bug with recurring meetings whereby events have started showing up with the incorrect time since the DST changeover. I am in the UK and the DST took place on Oct 30th. It might be related to the author of the calendar event being in Brasilia timezone where there is no DST changeover.

The meeting before DST changeover was at 16:15 on Monday's so should be now 15:15. However in the screenshot below you can see for next Monday it incorrectly shows two meetings one for 15:15 and one for 14:15 then for the following Mondays a single meeting at 14:15 (should be 15:15). If I try clicking on the 14:15 event nothing happens except an Event Not Found message popup.

Screenshot_20211104-101601

For reference here are the correct events in Google calendar

image
image

I have exported the events and settings from the widget:

I have also exported the original event:

@yvolk
Copy link
Member

yvolk commented Nov 8, 2021

Hello @cas-- As our widget doesn't store events anywhere, but only shows what the Android system service "Calendar provider" returns to it, so I would say that this is events synchronization bug/defect.

Please look at the related issue #17

@cas--
Copy link
Author

cas-- commented Nov 8, 2021

I did wonder if ToDo Agenda did any event conversion. Also useful to know for debugging that there is the Android calendar provider

ToDo Agenda uses "Calendar provider" Android service, working on this device whereas Google Calendar probably syncs with Google cloud directly. So different results are usually caused by Android "Calendar provider" sync problems, which may require user-forced re-syncing.

Anyway those events have been fixed by the event author updating to compensate for DST.

Thanks for keeping this super useful app updated 🎉

@cas-- cas-- closed this as completed Nov 8, 2021
@yvolk
Copy link
Member

yvolk commented Nov 9, 2021

I did wonder if ToDo Agenda did any event conversion

No time conversion is done for individual events. Actually date-time values come to our widget (according to the Android system-defined format) even without time zone as "the milliseconds from 1970-01-01T00:00:00Z"

We have "Lock time zone" feature for the whole widget instance though...

@cas--
Copy link
Author

cas-- commented Mar 3, 2022

I just worked out the primary reason for the timezone issue relates to outdated Android 9 timezone data.

https://source.android.com/devices/tech/config/timezone-rules#timezone-apk

I have a Sony XZ1 Compact which hasn't received an update to the timezone since 2019 and these updates have to come from OEM! This means that when Brazil stopped using DST in 2019, therefore for several weeks my calendar will show the wrong timezone for any events using Brazil timezone until my timezone changes...

@yvolk How difficult would it be to include timezone data fallback in the widget? 🤪

My other option is to install Lineage OS and hope I can keep DRM keys for camera 🤔

@yvolk
Copy link
Member

yvolk commented Mar 4, 2022

Hello @cas-- I think we simply need to update Time-related library in the widget itself. I will look into this.

@yvolk
Copy link
Member

yvolk commented Mar 9, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants