Skip to content

Commit 0868535

Browse files
committed
Migrate everything to media3's Log
To consistently allow apps to intercept logs and just be generally consistent in the project.
1 parent a4ec294 commit 0868535

File tree

15 files changed

+25
-35
lines changed

15 files changed

+25
-35
lines changed

libraries/exoplayer/src/main/java/androidx/media3/exoplayer/video/VideoDecoderGLSurfaceView.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@
2222
import android.opengl.GLES20;
2323
import android.opengl.GLSurfaceView;
2424
import android.util.AttributeSet;
25-
import android.util.Log;
2625
import androidx.annotation.Nullable;
2726
import androidx.media3.common.util.GlProgram;
2827
import androidx.media3.common.util.GlUtil;
28+
import androidx.media3.common.util.Log;
2929
import androidx.media3.common.util.NullableType;
3030
import androidx.media3.common.util.UnstableApi;
3131
import androidx.media3.decoder.VideoDecoderOutputBuffer;

libraries/exoplayer/src/main/java/androidx/media3/exoplayer/video/spherical/ProjectionRenderer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,11 @@
1919

2020
import android.opengl.GLES11Ext;
2121
import android.opengl.GLES20;
22-
import android.util.Log;
2322
import androidx.annotation.Nullable;
2423
import androidx.media3.common.C;
2524
import androidx.media3.common.util.GlProgram;
2625
import androidx.media3.common.util.GlUtil;
26+
import androidx.media3.common.util.Log;
2727
import java.nio.FloatBuffer;
2828
import org.checkerframework.checker.nullness.qual.MonotonicNonNull;
2929

libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpPcmReader.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
import static androidx.media3.exoplayer.rtsp.reader.RtpReaderUtils.toSampleTimeUs;
1919
import static com.google.common.base.Preconditions.checkNotNull;
2020

21-
import android.util.Log;
2221
import androidx.media3.common.C;
22+
import androidx.media3.common.util.Log;
2323
import androidx.media3.common.util.ParsableByteArray;
2424
import androidx.media3.common.util.UnstableApi;
2525
import androidx.media3.common.util.Util;

libraries/session/src/main/java/androidx/media3/session/MediaButtonReceiver.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ protected final void handleIntentAndMaybeStartTheService(
140140
if (intent == null
141141
|| !Objects.equals(intent.getAction(), Intent.ACTION_MEDIA_BUTTON)
142142
|| !intent.hasExtra(Intent.EXTRA_KEY_EVENT)) {
143-
android.util.Log.d(TAG, "Ignore unsupported intent: " + intent);
143+
Log.d(TAG, "Ignore unsupported intent: " + intent);
144144
return;
145145
}
146146

@@ -163,7 +163,7 @@ protected final void handleIntentAndMaybeStartTheService(
163163
// playback is started and the MediaSessionService/MediaLibraryService is put into the
164164
// foreground (see https://developer.android.com/media/legacy/media-buttons and
165165
// https://developer.android.com/about/versions/oreo/android-8.0-changes#back-all).
166-
android.util.Log.w(
166+
Log.w(
167167
TAG,
168168
"Ignore key event that is not a `play` command on API 26 or above to avoid an"
169169
+ " 'ForegroundServiceDidNotStartInTimeException'");

libraries/session/src/main/java/androidx/media3/session/legacy/MediaBrowserCompat.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,12 +65,12 @@
6565
import android.os.RemoteException;
6666
import android.support.v4.os.ResultReceiver;
6767
import android.text.TextUtils;
68-
import android.util.Log;
6968
import androidx.annotation.IntDef;
7069
import androidx.annotation.Nullable;
7170
import androidx.annotation.RequiresApi;
7271
import androidx.annotation.RestrictTo;
7372
import androidx.collection.ArrayMap;
73+
import androidx.media3.common.util.Log;
7474
import androidx.media3.common.util.NullableType;
7575
import androidx.media3.session.legacy.MediaControllerCompat.TransportControls;
7676
import java.lang.annotation.Retention;
@@ -108,7 +108,6 @@
108108
@RestrictTo(LIBRARY)
109109
public final class MediaBrowserCompat {
110110
static final String TAG = "MediaBrowserCompat";
111-
static final boolean DEBUG = Log.isLoggable(TAG, Log.DEBUG);
112111

113112
/**
114113
* Used as an int extra field to denote the page number to subscribe. The value of {@code
@@ -1219,9 +1218,7 @@ public void onLoadChildren(
12191218
// Check that the subscription is still subscribed.
12201219
Subscription subscription = parentId == null ? null : subscriptions.get(parentId);
12211220
if (subscription == null) {
1222-
if (DEBUG) {
1223-
Log.d(TAG, "onLoadChildren for id that isn't subscribed id=" + parentId);
1224-
}
1221+
Log.d(TAG, "onLoadChildren for id that isn't subscribed id=" + parentId);
12251222
return;
12261223
}
12271224

libraries/session/src/main/java/androidx/media3/session/legacy/MediaBrowserServiceCompat.java

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@
6666
import android.service.media.MediaBrowserService;
6767
import android.support.v4.os.ResultReceiver;
6868
import android.text.TextUtils;
69-
import android.util.Log;
7069
import androidx.annotation.CallSuper;
7170
import androidx.annotation.IntDef;
7271
import androidx.annotation.MainThread;
@@ -75,6 +74,7 @@
7574
import androidx.annotation.RestrictTo;
7675
import androidx.collection.ArrayMap;
7776
import androidx.core.util.Pair;
77+
import androidx.media3.common.util.Log;
7878
import androidx.media3.common.util.NullableType;
7979
import androidx.media3.common.util.Util;
8080
import androidx.media3.session.legacy.MediaSessionManager.RemoteUserInfo;
@@ -119,7 +119,6 @@
119119
@RestrictTo(LIBRARY)
120120
public abstract class MediaBrowserServiceCompat extends Service {
121121
static final String TAG = "MBServiceCompat";
122-
static final boolean DEBUG = Log.isLoggable(TAG, Log.DEBUG);
123122

124123
private static final float EPSILON = 0.00001f;
125124

@@ -1542,15 +1541,13 @@ void performLoadChildren(
15421541
@Override
15431542
void onResultSent(@Nullable List<MediaBrowserCompat.MediaItem> list) {
15441543
if (connections.get(checkNotNull(connection.callbacks).asBinder()) != connection) {
1545-
if (DEBUG) {
1546-
Log.d(
1547-
TAG,
1548-
"Not sending onLoadChildren result for connection that has"
1549-
+ " been disconnected. pkg="
1550-
+ connection.pkg
1551-
+ " id="
1552-
+ parentId);
1553-
}
1544+
Log.d(
1545+
TAG,
1546+
"Not sending onLoadChildren result for connection that has"
1547+
+ " been disconnected. pkg="
1548+
+ connection.pkg
1549+
+ " id="
1550+
+ parentId);
15541551
return;
15551552
}
15561553

libraries/session/src/main/java/androidx/media3/session/legacy/MediaButtonReceiver.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,12 @@
2727
import android.content.pm.PackageManager;
2828
import android.content.pm.ResolveInfo;
2929
import android.os.Build;
30-
import android.util.Log;
3130
import android.view.KeyEvent;
3231
import androidx.annotation.Nullable;
3332
import androidx.annotation.RequiresApi;
3433
import androidx.annotation.RestrictTo;
3534
import androidx.core.content.ContextCompat;
35+
import androidx.media3.common.util.Log;
3636
import java.util.List;
3737

3838
/**

libraries/session/src/main/java/androidx/media3/session/legacy/MediaControllerCompat.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,13 @@
3939
import android.os.RemoteException;
4040
import android.os.ResultReceiver;
4141
import android.text.TextUtils;
42-
import android.util.Log;
4342
import android.view.KeyEvent;
4443
import androidx.annotation.GuardedBy;
4544
import androidx.annotation.Nullable;
4645
import androidx.annotation.RequiresApi;
4746
import androidx.annotation.RestrictTo;
4847
import androidx.media3.common.AudioAttributes;
48+
import androidx.media3.common.util.Log;
4949
import androidx.media3.session.legacy.MediaSessionCompat.QueueItem;
5050
import androidx.media3.session.legacy.PlaybackStateCompat.CustomAction;
5151
import androidx.versionedparcelable.ParcelUtils;

libraries/session/src/main/java/androidx/media3/session/legacy/MediaMetadataCompat.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,11 @@
2525
import android.os.Bundle;
2626
import android.os.Parcel;
2727
import android.os.Parcelable;
28-
import android.util.Log;
2928
import androidx.annotation.Nullable;
3029
import androidx.annotation.RestrictTo;
3130
import androidx.annotation.StringDef;
3231
import androidx.collection.ArrayMap;
32+
import androidx.media3.common.util.Log;
3333
import androidx.media3.session.legacy.MediaControllerCompat.TransportControls;
3434
import java.lang.annotation.Retention;
3535
import java.lang.annotation.RetentionPolicy;

libraries/session/src/main/java/androidx/media3/session/legacy/MediaSessionCompat.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,14 +49,14 @@
4949
import android.os.ResultReceiver;
5050
import android.os.SystemClock;
5151
import android.text.TextUtils;
52-
import android.util.Log;
5352
import android.view.KeyEvent;
5453
import android.view.ViewConfiguration;
5554
import androidx.annotation.GuardedBy;
5655
import androidx.annotation.IntDef;
5756
import androidx.annotation.Nullable;
5857
import androidx.annotation.RequiresApi;
5958
import androidx.annotation.RestrictTo;
59+
import androidx.media3.common.util.Log;
6060
import androidx.media3.common.util.NullableType;
6161
import androidx.media3.session.legacy.MediaSessionManager.RemoteUserInfo;
6262
import androidx.versionedparcelable.ParcelUtils;

0 commit comments

Comments
 (0)