Is there any reason to prevent updates screenshots on the forked pull request?

[Jaehwa-Noh]

It made that decreasing a productivity.
Contributors have to update manually with a new redundant own forked their repository only for updating screenshots and have to waiting CI took it.
Any reasons that needs to prevent update the screenshots on a forked pull request?

Related #1697

[SimonMarquis]

Hi @Jaehwa-Noh, what do you mean?
External contributors do not have ownership on https://github.com/android/nowinandroid, for good reasons, so you first have to create code on your own fork.
And the main build workflow contains an automated detection of this, and will update your code accordingly:

nowinandroid/.github/workflows/Build.yaml

Lines 81 to 103 in a0f2786

	- name: Prevent pushing new screenshots if this is a fork
	id: checkfork_screenshots
	continue-on-error: false
	if: steps.screenshotsverify.outcome == 'failure' && github.event.pull_request.head.repo.full_name != github.repository
	run: |
	echo "::error::Screenshot tests failed, please create a PR in your fork first."
	echo "Your fork's CI will take screenshots for your fork."
	exit 1
	# Runs if previous job failed
	- name: Generate new screenshots if verification failed and it's a PR
	id: screenshotsrecord
	if: steps.screenshotsverify.outcome == 'failure' && github.event_name == 'pull_request'
	run: |
	./gradlew recordRoborazziDemoDebug
	- name: Push new screenshots if available
	uses: stefanzweifel/git-auto-commit-action@v5
	if: steps.screenshotsrecord.outcome == 'success'
	with:
	file_pattern: '*/*.png'
	disable_globbing: true
	commit_message: "🤖 Updates screenshots"

The only thing is you have to have a PR opened in your fork for this worfklow to run in the context of your fork. You can easily do that by changing the "base" when creating a PR.

[Jaehwa-Noh]

My intend is why the github action can't push new screenshots on my forked repository pull request as I set the base to nowinadnroid main.
Why github action can take screenshots when PR towards to my main forked repository, cannot do towards to nowinandroid repository?
What is the reason of prevent it?

[Jaehwa-Noh]

After a brief search, I get here and here.
stefanzweifel/git-auto-commit-action#211
#1756 (comment)

The reason is there's no way to do this with a secure way.

[JoseAlcerreca]

But also it's very easy to create a PR in your fork and let your action add the screenshots.

[Jaehwa-Noh]

No matter it is hard or easy, my point is contributors do additionaly actions for taking screenshots.
If the CI commit the screenshots directly in the contributors PR, just re-run the CI will update the screenshots.
When main branch updated related with UI or Theme, it is getting more complexity to do contributors.