Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] C++17 STL <charconv> implementation missing floating point functions #1574

Closed
Didgy74 opened this issue Aug 29, 2021 · 3 comments
Closed
Labels

Comments

@Didgy74
Copy link

Didgy74 commented Aug 29, 2021

Description

In NDK r23, trying to use any of the float-based functions from will result in a compiler error. From looking in the file Sdk\ndk\23.0.7599858\sources\cxx-stl\llvm-libc++\include\charconv, it's clear that this file only contains implementation for the integral types,

To clarify more, from the https://en.cppreference.com/w/cpp/utility/to_chars page, the current implementation only contains functions 1 and 2. From the https://en.cppreference.com/w/cpp/utility/from_chars page, the current implementation only contains function 1.

Test case:

Include and try to use any of the float based function:

#include <charconv>

char str[10];
std::from_chars_result result = std::to_chars(&str[0], &str[10], 10.f); // Compiler error, no matching candidate found.

Environment Details

  • NDK Version: 23.0.7599858
@Didgy74 Didgy74 added the bug label Aug 29, 2021
@DanAlbert
Copy link
Member

At a glance (not sure if I'm reading the enable-ifs correctly) it looks like this is still the case upstream, so this probably requires more than just a libc++ update.

@Zingam
Copy link

Zingam commented Sep 10, 2022

@DanAlbert
Copy link
Member

Duplicate of #1530

(these were added upstream a while back, we just need an update)

@DanAlbert DanAlbert closed this as not planned Won't fix, can't repro, duplicate, stale Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants