From 6e99419c8bcac537766a5441fab815e2afc376d9 Mon Sep 17 00:00:00 2001 From: Chris Arriola Date: Mon, 26 Feb 2024 17:41:15 -0800 Subject: [PATCH 1/2] [Jetcaster] Center followed podcast and improve scrolling. --- .../com/example/jetcaster/ui/home/Home.kt | 3 +- .../ui/home/category/PodcastCategory.kt | 41 ++++++++----------- 2 files changed, 18 insertions(+), 26 deletions(-) diff --git a/Jetcaster/app/src/main/java/com/example/jetcaster/ui/home/Home.kt b/Jetcaster/app/src/main/java/com/example/jetcaster/ui/home/Home.kt index f9dee7eb07..5d3cda2a92 100644 --- a/Jetcaster/app/src/main/java/com/example/jetcaster/ui/home/Home.kt +++ b/Jetcaster/app/src/main/java/com/example/jetcaster/ui/home/Home.kt @@ -26,7 +26,6 @@ import androidx.compose.foundation.layout.Spacer import androidx.compose.foundation.layout.WindowInsets import androidx.compose.foundation.layout.WindowInsetsSides import androidx.compose.foundation.layout.aspectRatio -import androidx.compose.foundation.layout.fillMaxHeight import androidx.compose.foundation.layout.fillMaxSize import androidx.compose.foundation.layout.fillMaxWidth import androidx.compose.foundation.layout.height @@ -338,7 +337,7 @@ fun FollowedPodcasts( lastEpisodeDateText = lastEpisodeDate?.let { lastUpdated(it) }, modifier = Modifier .padding(4.dp) - .fillMaxHeight() + .fillMaxSize() ) } } diff --git a/Jetcaster/app/src/main/java/com/example/jetcaster/ui/home/category/PodcastCategory.kt b/Jetcaster/app/src/main/java/com/example/jetcaster/ui/home/category/PodcastCategory.kt index 25d88ec704..492d330a38 100644 --- a/Jetcaster/app/src/main/java/com/example/jetcaster/ui/home/category/PodcastCategory.kt +++ b/Jetcaster/app/src/main/java/com/example/jetcaster/ui/home/category/PodcastCategory.kt @@ -106,9 +106,23 @@ fun PodcastCategory( /** * TODO: reset scroll position when category changes */ - Column(modifier = modifier) { - CategoryPodcasts(viewState.topPodcasts, viewModel) - EpisodeList(viewState.episodes, navigateToPlayer) + LazyColumn( + contentPadding = PaddingValues(0.dp), + verticalArrangement = Arrangement.Center, + modifier = modifier + ) { + item { + CategoryPodcasts(viewState.topPodcasts, viewModel) + } + + items(viewState.episodes, key = { it.episode.uri }) { item -> + EpisodeListItem( + episode = item.episode, + podcast = item.podcast, + onClick = navigateToPlayer, + modifier = Modifier.fillParentMaxWidth() + ) + } } } @@ -124,27 +138,6 @@ private fun CategoryPodcasts( ) } -@Composable -private fun EpisodeList( - episodes: List, - navigateToPlayer: (String) -> Unit -) { - LazyColumn( - contentPadding = PaddingValues(0.dp), - verticalArrangement = Arrangement.Center - ) { - - items(episodes, key = { it.episode.uri }) { item -> - EpisodeListItem( - episode = item.episode, - podcast = item.podcast, - onClick = navigateToPlayer, - modifier = Modifier.fillParentMaxWidth() - ) - } - } -} - @Composable fun EpisodeListItem( episode: Episode, From 3849a92fde7b5c42c8030b4db115da3595c8477e Mon Sep 17 00:00:00 2001 From: arriolac Date: Tue, 27 Feb 2024 01:46:55 +0000 Subject: [PATCH 2/2] =?UTF-8?q?=F0=9F=A4=96=20Apply=20Spotless?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../com/example/jetcaster/ui/home/category/PodcastCategory.kt | 1 - 1 file changed, 1 deletion(-) diff --git a/Jetcaster/app/src/main/java/com/example/jetcaster/ui/home/category/PodcastCategory.kt b/Jetcaster/app/src/main/java/com/example/jetcaster/ui/home/category/PodcastCategory.kt index 492d330a38..1b82eb09b2 100644 --- a/Jetcaster/app/src/main/java/com/example/jetcaster/ui/home/category/PodcastCategory.kt +++ b/Jetcaster/app/src/main/java/com/example/jetcaster/ui/home/category/PodcastCategory.kt @@ -73,7 +73,6 @@ import coil.compose.AsyncImage import coil.request.ImageRequest import com.example.jetcaster.R import com.example.jetcaster.data.Episode -import com.example.jetcaster.data.EpisodeToPodcast import com.example.jetcaster.data.Podcast import com.example.jetcaster.data.PodcastWithExtraInfo import com.example.jetcaster.ui.home.PreviewEpisodes