Skip to content

Commit 08fc6a9

Browse files
committed
Remove icon usage from Jetsnack, replace with hardcoded icons.
1 parent 38afa97 commit 08fc6a9

File tree

6 files changed

+18
-22
lines changed

6 files changed

+18
-22
lines changed

Jetsnack/app/src/main/java/com/example/jetsnack/ui/components/Snacks.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,6 @@ import androidx.compose.foundation.lazy.itemsIndexed
4949
import androidx.compose.foundation.lazy.rememberLazyListState
5050
import androidx.compose.foundation.shape.CircleShape
5151
import androidx.compose.foundation.shape.RoundedCornerShape
52-
import androidx.compose.material.icons.Icons
53-
import androidx.compose.material.icons.automirrored.outlined.ArrowBack
5452
import androidx.compose.material3.Icon
5553
import androidx.compose.material3.IconButton
5654
import androidx.compose.material3.MaterialTheme
@@ -121,7 +119,7 @@ fun SnackCollection(
121119
modifier = Modifier.align(Alignment.CenterVertically),
122120
) {
123121
Icon(
124-
imageVector = Icons.AutoMirrored.Outlined.ArrowBack,
122+
painter = painterResource(id = R.drawable.ic_arrow_back),
125123
tint = JetsnackTheme.colors.brand,
126124
contentDescription = null,
127125
)

Jetsnack/app/src/main/java/com/example/jetsnack/ui/home/search/Results.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@ import androidx.compose.foundation.layout.wrapContentSize
3131
import androidx.compose.foundation.lazy.LazyColumn
3232
import androidx.compose.foundation.lazy.itemsIndexed
3333
import androidx.compose.foundation.shape.CircleShape
34-
import androidx.compose.material.icons.Icons
35-
import androidx.compose.material.icons.outlined.Add
3634
import androidx.compose.material3.Icon
3735
import androidx.compose.material3.MaterialTheme
3836
import androidx.compose.material3.Text
@@ -167,7 +165,7 @@ private fun SearchResult(snack: Snack, onSnackClick: (Long, String) -> Unit, sho
167165
},
168166
) {
169167
Icon(
170-
imageVector = Icons.Outlined.Add,
168+
painter = painterResource(id = R.drawable.ic_add),
171169
contentDescription = stringResource(R.string.label_add),
172170
)
173171
}

Jetsnack/app/src/main/java/com/example/jetsnack/ui/home/search/Search.kt

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,6 @@ import androidx.compose.foundation.layout.width
3131
import androidx.compose.foundation.layout.wrapContentHeight
3232
import androidx.compose.foundation.layout.wrapContentSize
3333
import androidx.compose.foundation.text.BasicTextField
34-
import androidx.compose.material.icons.Icons
35-
import androidx.compose.material.icons.automirrored.outlined.ArrowBack
36-
import androidx.compose.material.icons.outlined.Search
3734
import androidx.compose.material3.CircularProgressIndicator
3835
import androidx.compose.material3.Icon
3936
import androidx.compose.material3.IconButton
@@ -49,6 +46,7 @@ import androidx.compose.runtime.setValue
4946
import androidx.compose.ui.Alignment
5047
import androidx.compose.ui.Modifier
5148
import androidx.compose.ui.focus.onFocusChanged
49+
import androidx.compose.ui.res.painterResource
5250
import androidx.compose.ui.res.stringResource
5351
import androidx.compose.ui.text.input.TextFieldValue
5452
import androidx.compose.ui.tooling.preview.Preview
@@ -192,7 +190,7 @@ private fun SearchBar(
192190
if (searchFocused) {
193191
IconButton(onClick = onClearQuery) {
194192
Icon(
195-
imageVector = Icons.AutoMirrored.Outlined.ArrowBack,
193+
painter = painterResource(id = R.drawable.ic_arrow_back),
196194
tint = JetsnackTheme.colors.iconPrimary,
197195
contentDescription = stringResource(R.string.label_back),
198196
)
@@ -233,7 +231,7 @@ private fun SearchHint() {
233231
.wrapContentSize(),
234232
) {
235233
Icon(
236-
imageVector = Icons.Outlined.Search,
234+
painter = painterResource(id = R.drawable.ic_search),
237235
tint = JetsnackTheme.colors.textHelp,
238236
contentDescription = stringResource(R.string.label_search),
239237
)

Jetsnack/app/src/main/java/com/example/jetsnack/ui/snackdetail/SnackDetail.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,6 @@ import androidx.compose.foundation.rememberScrollState
6262
import androidx.compose.foundation.shape.CircleShape
6363
import androidx.compose.foundation.shape.RoundedCornerShape
6464
import androidx.compose.foundation.verticalScroll
65-
import androidx.compose.material.icons.Icons
66-
import androidx.compose.material.icons.automirrored.outlined.ArrowBack
6765
import androidx.compose.material3.Icon
6866
import androidx.compose.material3.IconButton
6967
import androidx.compose.material3.MaterialTheme
@@ -85,6 +83,7 @@ import androidx.compose.ui.graphics.Brush
8583
import androidx.compose.ui.graphics.TileMode
8684
import androidx.compose.ui.layout.Layout
8785
import androidx.compose.ui.platform.LocalDensity
86+
import androidx.compose.ui.res.painterResource
8887
import androidx.compose.ui.res.stringResource
8988
import androidx.compose.ui.text.font.FontStyle
9089
import androidx.compose.ui.text.style.TextAlign
@@ -271,7 +270,7 @@ private fun SharedTransitionScope.Up(upPress: () -> Unit) {
271270
),
272271
) {
273272
Icon(
274-
imageVector = Icons.AutoMirrored.Outlined.ArrowBack,
273+
painter = painterResource(id = R.drawable.ic_arrow_back),
275274
tint = JetsnackTheme.colors.iconInteractive,
276275
contentDescription = stringResource(R.string.label_back),
277276
)
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
<vector xmlns:android="http://schemas.android.com/apk/res/android"
2+
android:width="24dp"
3+
android:height="24dp"
4+
android:viewportWidth="24"
5+
android:viewportHeight="24"
6+
android:tint="#FF000000">
7+
<path
8+
android:fillColor="@android:color/white"
9+
android:pathData="M20,11H7.83l5.59,-5.59L12,4l-8,8 8,8 1.41,-1.41L7.83,13H20v-2z"/>
10+
</vector>

Jetsnack/gradle/libs.versions.toml

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
#####
2-
# This file is duplicated to individual samples from the global scripts/libs.versions.toml
3-
# Do not add a dependency to an individual sample, edit the global version instead.
4-
#####
51
[versions]
62
accompanist = "0.37.3"
73
android-material3 = "1.14.0-alpha04"
@@ -56,7 +52,7 @@ room = "2.8.1"
5652
secrets = "2.0.1"
5753
spotless = "8.0.0"
5854
# @keep
59-
targetSdk = "33"
55+
targetSdk = "36"
6056
version-catalog-update = "1.0.0"
6157

6258
[libraries]
@@ -70,7 +66,6 @@ androidx-compose-animation = { module = "androidx.compose.animation:animation" }
7066
androidx-compose-bom = { module = "androidx.compose:compose-bom", version.ref = "androidx-compose-bom" }
7167
androidx-compose-foundation = { module = "androidx.compose.foundation:foundation" }
7268
androidx-compose-foundation-layout = { module = "androidx.compose.foundation:foundation-layout" }
73-
androidx-compose-material-iconsExtended = { module = "androidx.compose.material:material-icons-extended" }
7469
androidx-compose-material3 = { module = "androidx.compose.material3:material3" }
7570
androidx-compose-material3-adaptive = { module = "androidx.compose.material3.adaptive:adaptive" }
7671
androidx-compose-material3-adaptive-layout = { module = "androidx.compose.material3.adaptive:adaptive-layout" }
@@ -98,13 +93,11 @@ androidx-glance-appwidget = { module = "androidx.glance:glance-appwidget", versi
9893
androidx-glance-material3 = { module = "androidx.glance:glance-material3", version.ref = "androidx-glance" }
9994
androidx-glance-preview = { module = "androidx.glance:glance-preview", version.ref = "glancePreview" }
10095
androidx-hilt-navigation-compose = { module = "androidx.hilt:hilt-navigation-compose", version.ref = "androidxHiltNavigationCompose" }
101-
androidx-lifecycle-livedata-ktx = { module = "androidx.lifecycle:lifecycle-viewmodel-ktx", version.ref = "androidx-lifecycle-compose" }
10296
androidx-lifecycle-runtime = { module = "androidx.lifecycle:lifecycle-runtime-ktx", version.ref = "androidx-lifecycle-compose" }
10397
androidx-lifecycle-runtime-compose = { module = "androidx.lifecycle:lifecycle-runtime-compose", version.ref = "androidx-lifecycle-runtime-compose" }
10498
androidx-lifecycle-viewModelCompose = { module = "androidx.lifecycle:lifecycle-viewmodel-compose", version.ref = "androidx-lifecycle-compose" }
10599
androidx-lifecycle-viewmodel-ktx = { module = "androidx.lifecycle:lifecycle-viewmodel-ktx", version.ref = "androidx-lifecycle-compose" }
106100
androidx-lifecycle-viewmodel-savedstate = { module = "androidx.lifecycle:lifecycle-viewmodel-savedstate", version.ref = "androidx-lifecycle-compose" }
107-
androidx-material-icons-core = { module = "androidx.compose.material:material-icons-core" }
108101
androidx-navigation-compose = { module = "androidx.navigation:navigation-compose", version.ref = "androidx-navigation" }
109102
androidx-navigation-fragment = { module = "androidx.navigation:navigation-fragment-ktx", version.ref = "androidx-navigation" }
110103
androidx-navigation-ui-ktx = { module = "androidx.navigation:navigation-ui-ktx", version.ref = "androidx-navigation" }

0 commit comments

Comments
 (0)