Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile error when using clang and precompiled headers #16

Closed
DoDoENT opened this issue Mar 14, 2016 · 2 comments
Closed

Compile error when using clang and precompiled headers #16

DoDoENT opened this issue Mar 14, 2016 · 2 comments
Assignees
@DanAlbert
Milestone
r12

Comments

@DoDoENT
Copy link

DoDoENT commented Mar 14, 2016

In my Application.mk I've set NDK_TOOLCHAIN_VERSION=clang and in Android.mk I've defined LOCAL_PCH to point header I wish to get precompiled.

With GCC (NDK_TOOLCHAIN_VERSION unset), project can be built successfully. With clang I get following errors:

clang++: error: treating 'c-header' input as 'c++-header' when in C++ mode, this behavior is deprecated
@DoDoENT
Copy link
Author

DoDoENT commented Mar 14, 2016

It appears this can be fixed by adding following line to $NDK_DIR/build/core/build-binary.mk:

Around line 440, below comment #Build PCH and above $(call compile-cpp-source,$(LOCAL_PCH),$(LOCAL_BUILT_PCH).gch) add this line:

LOCAL_SRC_FILES_TARGET_CFLAGS.$(LOCAL_PCH) += -x c++-header

@DanAlbert
Copy link
Member

Thanks again! Added a test case and uploaded for review: https://android-review.googlesource.com/208223

@DanAlbert DanAlbert self-assigned this Mar 14, 2016
@DanAlbert DanAlbert added this to the r12 milestone Mar 14, 2016
@dipankar08 dipankar08 mentioned this issue Mar 28, 2016
Closed
DanAlbert added a commit that referenced this issue Apr 16, 2016
@DanAlbert
Silence clang's whining for PCH files.
da081ef 
Clang whines about a "c-header" (.h rather than .hpp) being used in
C++ mode (note that we use compile-cpp-source to build the header).
Tell clang that we're building it as C++.

Patch contributed by @DoDoENT.

Bug: #16
Change-Id: I50803003394f28cf4f92faef13cd6ed680cbf77c
Closed
@stephenhines stephenhines mentioned this issue May 16, 2017
Closed
@dantipov dantipov mentioned this issue Jan 25, 2018
Closed
@dan-ryan dan-ryan mentioned this issue Sep 11, 2018
Closed
@alervd alervd mentioned this issue Oct 1, 2019
Closed
@chrisbabcock-epic chrisbabcock-epic mentioned this issue Feb 6, 2020
Closed
@qwandor-google qwandor-google mentioned this issue Apr 3, 2020
Closed
@xphcyh xphcyh mentioned this issue Jul 16, 2020
Closed
@kyoungjib kyoungjib mentioned this issue Nov 24, 2020
Closed
@MasterLi186 MasterLi186 mentioned this issue Dec 16, 2020
Closed
@ningjingzhiyuan-mj ningjingzhiyuan-mj mentioned this issue May 12, 2021
Open
@prabhatKrMishra prabhatKrMishra mentioned this issue May 25, 2021
Closed
@fandashi18 fandashi18 mentioned this issue May 25, 2021
Closed
@AlexanderSerov AlexanderSerov mentioned this issue Jun 7, 2021
Closed
@zte-majiang zte-majiang mentioned this issue Sep 26, 2021
Closed
@Over17 Over17 mentioned this issue Dec 6, 2021
Closed
@niinorz niinorz mentioned this issue Jul 11, 2022
Closed
@honggang0524 honggang0524 mentioned this issue Nov 28, 2022
Closed
@raju535482 raju535482 mentioned this issue Nov 28, 2022
Closed
This was referenced May 22, 2023
Closed
Closed
@edishan edishan mentioned this issue Jun 28, 2023
Closed
@VijayLi11 VijayLi11 mentioned this issue Jul 6, 2023
Closed
@seoil0728 seoil0728 mentioned this issue Nov 29, 2023
Closed
@WangYisi225 WangYisi225 mentioned this issue Dec 19, 2023
Closed
@ValleZ ValleZ mentioned this issue Feb 11, 2024
Closed
@dcosmin-97 dcosmin-97 mentioned this issue Mar 31, 2024
Closed
@yujincheng08 yujincheng08 mentioned this issue Apr 11, 2024
Closed
@sruPL sruPL mentioned this issue Apr 30, 2024
Closed
@notyalcs notyalcs mentioned this issue May 24, 2024
Closed
@ivanovichgames ivanovichgames mentioned this issue Jun 20, 2024
Closed
@JerryWang-0 JerryWang-0 mentioned this issue Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanAlbert DanAlbert

Labels
None yet
Projects
None yet
Milestone
r12
Development

No branches or pull requests
2 participants
@DoDoENT @DanAlbert