Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why Promise? #80

Open
vforchi opened this issue Dec 4, 2024 · 0 comments
Open

Why Promise? #80

vforchi opened this issue Dec 4, 2024 · 0 comments

Comments

@vforchi
Copy link

vforchi commented Dec 4, 2024

Hi, I just installed this library and I wonder why all the methods of Star return Promise.
It all comes from

    public async getGeocentricEquatorialSphericalJ2000Coordinates(): Promise<EquatorialSphericalCoordinates> {
        return Promise.resolve(this.equatorialCoords);
    }

But why is this returning a Promise, since it does not do any IO or blocking operation? It seems like an unnecessary complication of the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant