Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getUpcomingNewMoon() and getUpcomingFullMoon() are often incorrect when close to the event #75

Open
willem-syt opened this issue Jan 2, 2024 · 0 comments

Comments

@willem-syt
Copy link

Hi,
First of all, thank you for this great library.

I did notice that when you calculate e.g. New Moon for 2024-01-15 12:00:00 (UTC) the result will be in the past (i.e. 2024-01-11 11:58:48).
Similarly a Full Moon calculation for 2024-01-24 12:00:00 gives 2024-02-24 12:31:24 (it should be 2024-01-25 17:55:01):

2024-01-15 12:00:00 Full Moon 2024-01-25 17:55:01
2024-01-16 12:00:00 Full Moon 2024-01-25 17:55:01
2024-01-17 12:00:00 Full Moon 2024-01-25 17:55:01
2024-01-18 12:00:00 Full Moon 2024-01-25 17:55:01
2024-01-19 12:00:00 Full Moon 2024-01-25 17:55:01
2024-01-20 12:00:00 Full Moon 2024-02-24 12:31:24
2024-01-21 12:00:00 Full Moon 2024-02-24 12:31:24
2024-01-22 12:00:00 Full Moon 2024-02-24 12:31:24
2024-01-23 12:00:00 Full Moon 2024-02-24 12:31:24
2024-01-24 12:00:00 Full Moon 2024-02-24 12:31:24
2024-01-25 12:00:00 Full Moon 2024-02-24 12:31:24
2024-01-26 12:00:00 Full Moon 2024-02-24 12:31:24

At this moment I check the results and re-calculate with a different date if needed.

Next to that it would be nice to add the Age (in days) for the Moon (i.e. 0 at New Moon and ~14.7 at Full Moon). At the moment I calculate this by determining the previous New Moon event and subtracting it from the ToI.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant