Skip to content

Angular diameter return value unit should be specified #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aleksati opened this issue Jan 2, 2022 · 0 comments
Open

Angular diameter return value unit should be specified #69

aleksati opened this issue Jan 2, 2022 · 0 comments

Comments

@aleksati
Copy link

aleksati commented Jan 2, 2022

EDIT:

Hey,

I am currently using your library in a project and have a question about one of its methods. My result from doing an angular diameter calculation of Jupiter (with your method) reads 0.009806. After reading the documentation, I interpreted this number to represent 98.06 arc seconds because:

Diameter: 0°. 00' 00"

However, that does not make much sense. 0.0098° should not be read as 98 arc seconds. One arc seconds = degrees° * 3600. So 0.0098° * 3600 = 35.28''. further reading your code I realized that the output is in degrees and that further conversion is needed for the result become arc minutes or seconds. I suggest you make this clear in your documentation as to not spur further confusion.

Great library, by the way!
All the best,
Aleks T.

@aleksati aleksati changed the title Angular diameter question Angular diameter issue Jan 2, 2022
@aleksati aleksati changed the title Angular diameter issue Angular diameter return value unit should be specified Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant