Skip to content

Commit 2c803e8

Browse files
author
Terry Worona
committed
cleaned up strings
1 parent 7efeaa1 commit 2c803e8

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

JBChartViewDemo/JBChartViewDemo.xcodeproj/project.pbxproj

+2-2
Original file line numberDiff line numberDiff line change
@@ -199,10 +199,10 @@
199199
9B6A68DD1829BE63006DB3BF /* JBBarChartViewController.m */,
200200
9B07251F1829822A0052109B /* JBChartListViewController.h */,
201201
9B0725201829822A0052109B /* JBChartListViewController.m */,
202-
9B6A68DF1829BED5006DB3BF /* JBLineChartViewController.h */,
203-
9B6A68E01829BED5006DB3BF /* JBLineChartViewController.m */,
204202
94BDFC3219F933B2007492F6 /* JBLineChartMissingPointsViewController.h */,
205203
94BDFC3319F933B2007492F6 /* JBLineChartMissingPointsViewController.m */,
204+
9B6A68DF1829BED5006DB3BF /* JBLineChartViewController.h */,
205+
9B6A68E01829BED5006DB3BF /* JBLineChartViewController.m */,
206206
);
207207
path = Controllers;
208208
sourceTree = "<group>";

JBChartViewDemo/JBChartViewDemo/Constants/JBStringConstants.h

+4-4
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@
4242
#pragma mark - Labels (Missing Points Line Chart)
4343

4444
#define kJBStringLabel2014 localize(@"label.2014", @"2014")
45-
#define kJBStringLabelCyclingCurrentWeek2014 localize(@"label.cycling.2014", @"Cycling - 2014")
46-
#define kJBStringLabelCyclingCurrentWeekLastWeek2014 localize(@"label.current.last.week.cycling", @"Cycling Current Week and Last Year Week")
45+
#define kJBStringLabelCyclingDistances localize(@"label.cycling.distances", @"Cycling Distances")
46+
#define kJBStringLabelCyclingCurrentLastWeek2014 localize(@"label.cycling.current.last.week.2014", @"Current/Last Week - 2014")
4747
#define kJBStringLabelKm2014 localize(@"label.km", @"Km")
48-
#define kJBStringLabelLastYear2014 localize(@"label.last.average", @"Last Year")
49-
#define kJBStringLabelCurrentYear2014 localize(@"label.current.average", @"Current Year")
48+
#define kJBStringLabelLastWeek localize(@"label.last.week", @"Last Week")
49+
#define kJBStringLabelCurrentWeek localize(@"label.current.week", @"Current Week")

JBChartViewDemo/JBChartViewDemo/Controllers/JBChartListViewController.m

+2-2
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,8 @@ - (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(N
7676
type = JBChartTableCellTypeAreaChart;
7777
break;
7878
case JBChartListViewControllerRowLineChartMissingPoints:
79-
text = kJBStringLabelCyclingCurrentWeek2014;
80-
detailText = kJBStringLabelCyclingCurrentWeekLastWeek2014;
79+
text = kJBStringLabelCyclingDistances;
80+
detailText = kJBStringLabelCyclingCurrentLastWeek2014;
8181
type = JBChartTableCellTypeLineChart;
8282
break;
8383
default:

JBChartViewDemo/JBChartViewDemo/Controllers/JBLineChartMissingPointsViewController.m

+2-2
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ - (void)loadView
138138
self.lineChartView.backgroundColor = kJBColorLineChartBackground;
139139

140140
JBChartHeaderView *headerView = [[JBChartHeaderView alloc] initWithFrame:CGRectMake(kJBLineChartMissingPointsViewControllerChartPadding, ceil(self.view.bounds.size.height * 0.5) - ceil(kJBLineChartMissingPointsViewControllerChartHeaderHeight * 0.5), self.view.bounds.size.width - (kJBLineChartMissingPointsViewControllerChartPadding * 2), kJBLineChartMissingPointsViewControllerChartHeaderHeight)];
141-
headerView.titleLabel.text = [kJBStringLabelCyclingCurrentWeek2014 uppercaseString];
141+
headerView.titleLabel.text = [kJBStringLabelCyclingDistances uppercaseString];
142142
headerView.titleLabel.textColor = kJBColorLineChartHeader;
143143
headerView.titleLabel.shadowColor = [UIColor colorWithWhite:1.0 alpha:0.25];
144144
headerView.titleLabel.shadowOffset = CGSizeMake(0, 1);
@@ -224,7 +224,7 @@ - (void)lineChartView:(JBLineChartView *)lineChartView didSelectLineAtIndex:(NSU
224224
[self.informationView setHidden:YES animated:YES];
225225
} else {
226226
[self.informationView setValueText:[NSString stringWithFormat:@"%.2f", [valueNumber floatValue]] unitText:kJBStringLabelKm2014];
227-
[self.informationView setTitleText:lineIndex == JBLineChartLineSolid ? kJBStringLabelLastYear2014 : kJBStringLabelCurrentYear2014];
227+
[self.informationView setTitleText:lineIndex == JBLineChartLineSolid ? kJBStringLabelLastWeek : kJBStringLabelCurrentWeek];
228228
[self.informationView setHidden:NO animated:YES];
229229
}
230230
[self setTooltipVisible:YES animated:YES atTouchPoint:touchPoint];

0 commit comments

Comments
 (0)