feat: enable v6 database #2439
Open
feat: enable v6 database #2439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
kzantow
commented
Feb 20, 2025
| return nil, fmt.Errorf("unable to get vulnerability store metadata: %w", err) | ||
| } | ||
|
|
||
| _, err = c.validate(db.DescriptionFromMetadata(m), c.config.ValidateChecksum) |
There was a problem hiding this comment.
This was causing the db to be hashed twice, since the .Status() call is also hashing the db and validating age and is required (db status is required to be passed to the presenters), I've removed the validation from this call altogether.
kzantow
commented
Feb 20, 2025
Signed-off-by: Keith Zantow <[email protected]>
…tion Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
kzantow
commented
Feb 21, 2025
| }, | ||
| }, | ||
| { | ||
| name: "db status: valid db fails with hash mismatch", |
There was a problem hiding this comment.
This case handles: #1648
Signed-off-by: Keith Zantow <[email protected]>
kzantow
commented
Feb 21, 2025
| }, | ||
| }, | ||
| { | ||
| name: "db status: missing db returns error", |
There was a problem hiding this comment.
This test case handles: #2077
Signed-off-by: Keith Zantow <[email protected]>
kzantow
commented
Feb 21, 2025
| "github.com/anchore/clio" | ||
| "github.com/anchore/grype/grype/db" | ||
| ) | ||
|
|
||
| // Experimental options are opt-in features that are... | ||
| // ...not stable | ||
| // ...not yet fully supported | ||
| // ...not necessarily tested | ||
| // ...not ready for production use | ||
| // these may go away at any moment, do not depend on them | ||
| type Experimental struct { |
There was a problem hiding this comment.
should we remove this struct altogether?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes v5 database support from Grype, moving support to v6 databases. The
db/v5package needs to remain, however, as we will continue building v5 databases with functionality from that package ingrype-db.Closes #2129
Closes #2126
Fixes #2459
Fixes #1648
Fixes #2077
Enables previously implemented functionality:
searchoutput #2130legacypackage #2124