Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package introduces undocumented and unwanted collapsible groups, and other issues #3

Open
vesper8 opened this issue May 26, 2020 · 4 comments

Comments

@vesper8
Copy link

vesper8 commented May 26, 2020

I just noticed after installing this package and setting it up that it turned all my resource groups into collapsible dropdowns.

Why does it do that? This package doesn't mention this anywhere. This is only supposed to add icons to resources

At least if there was a config file where I could disable this collapsible behaviour, or how about configuring it so that all groups are expanded by default?

Another thing, I've noticed that icons in groups are not properly aligned with the resource and are slightly higher, see screenshot

Screen Shot 2020-05-26 at 1 32 14 PM

Lastly, I would have wanted the default behaviour (if no icon method is added) to be that no icon is shown for those resources.. instead right now it adds a default icon which is not configurable and undesired.

Thanks for the effort, I would definitely use it once these things were fixed.

Regards

@MikeCraig418
Copy link

☝️ I used this on another project and it worked really well! I just noticed the grouping on another project today 🤦 .

+1 to make this a configurable option

@SuhaibKotb
Copy link

+1

@jerearaujo03
Copy link

Did you solved?

@bilogic
Copy link

bilogic commented Aug 10, 2021

I think this is because the package overrides the navigation blade entirely.
Probably need to merge the latest Nova navigation blade with https://github.com/anaseqal/nova-sidebar-icons/blob/master/resources/views/resources/navigation.blade.php.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants