Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the names of the scripts are not correct #33

Closed
amtoine opened this issue Oct 6, 2022 · 7 comments · Fixed by #38
Closed

the names of the scripts are not correct #33

amtoine opened this issue Oct 6, 2022 · 7 comments · Fixed by #38
Assignees
Labels
help wanted Extra attention is needed needs-triage An issue or a PR without label

Comments

@amtoine
Copy link
Owner

amtoine commented Oct 6, 2022

Since we moved from my personal dotfiles to the goatfiles, a few things are not correct anymore regarding the scripts themselves:

  • as stated in The headers are not correct anymore #18, the headers mention the (very) old a2n-s and need to be changed
  • the scripts are called amtoine-*, which does not fit anymore in the current plan...

as our new config is called "goatfiles", i thought we could (1) simplify the names of the scripts and (2) use the "goat" idea at the same time and (3) take inspiration from existing commands
let me give you some examples 😏:

  • amtoine-hdmi could be called grandr: a play on words with xrandr and goat, that's the xrandr for GOATs
  • amtoine-sound could be called gmixer: reference to amixer and pulsemixer, but now got GOATs
  • ...

what d'you reckon? 😋

@amtoine amtoine self-assigned this Oct 6, 2022
@amtoine
Copy link
Owner Author

amtoine commented Oct 6, 2022

work would then have to be done in the dotfiles to replace the old script names with the new ones 👍

@amtoine
Copy link
Owner Author

amtoine commented Oct 6, 2022

and we should not forget about the two example config files in ./examples whose names are not correct anymore as well 😌

@amtoine amtoine pinned this issue Oct 6, 2022
@amtoine
Copy link
Owner Author

amtoine commented Oct 6, 2022

below is the list of all the scripts which are explicitely used somewhere in the config

╭────┬─────────────────────╮
│  0 │ amtoine-battery     │
│  1 │ amtoine-gh-notify   │
│  2 │ amtoine-hdmi        │
│  3 │ amtoine-macho       │
│  4 │ amtoine-mocp        │
│  5 │ amtoine-pcm         │
│  6 │ amtoine-pdf         │
│  7 │ amtoine-scrot       │
│  8 │ amtoine-sound       │
│  9 │ amtoine-spark       │
│ 10 │ amtoine-sys-stats   │
│ 11 │ amtoine-themes      │
│ 12 │ amtoine-time-date   │
│ 13 │ amtoine-update      │
│ 14 │ amtoine-weather-get │
│ 15 │ amtoine-wfzf        │
│ 16 │ amtoine-wtldr       │
│ 17 │ amtoine-xtcl        │
╰────┴─────────────────────╯

which means, given the list of supported scripts in goatfiles/scripts, that

╭────┬───────────────────────────────╮
│  0 │ amtoine-apply-to-hunks        │
│  1 │ amtoine-compute-color-palette │
│  2 │ amtoine-countdown             │
│  3 │ amtoine-dmrun                 │
│  4 │ amtoine-lcfg                  │
│  5 │ amtoine-lfrun                 │
│  6 │ amtoine-list-monitors         │
│  7 │ amtoine-open                  │
│  8 │ amtoine-pedit                 │
│  9 │ amtoine-prompt                │
│ 10 │ amtoine-slock                 │
│ 11 │ amtoine-surf-open             │
│ 12 │ amtoine-syssync               │
│ 13 │ amtoine-tcfg                  │
│ 14 │ amtoine-togkb                 │
│ 15 │ amtoine-tr2md                 │
│ 16 │ amtoine-upl                   │
│ 17 │ amtoine-vdl                   │
│ 18 │ amtoine-wvenv                 │
│ 19 │ amtoine-xal                   │
│ 20 │ amtoine-ytdl                  │
╰────┴───────────────────────────────╯

are not used explicitely anywhere in the dotfiles
and that amtoine-themes does not exist anymore...

however, i consider the following scripts important and could use them sometimes

╭───┬───────────────────────────────╮
│ 0 │ amtoine-apply-to-hunks        │
│ 1 │ amtoine-compute-color-palette │
│ 2 │ amtoine-lfrun                 │
│ 3 │ amtoine-list-monitors         │
│ 4 │ amtoine-prompt                │
│ 5 │ amtoine-syssync               │
│ 6 │ amtoine-togkb                 │
│ 7 │ amtoine-upl                   │
│ 8 │ amtoine-ytdl                  │
╰───┴───────────────────────────────╯

details

the list of files containing the name of these scripts has been generated with

cfg lf |
  lines |
  each {
    |it|
    grep -H 'amtoine-' $it
  } |
  lines |
  split column ":" |
  get column1 |
  sort |
  uniq

@amtoine amtoine added the help wanted Extra attention is needed label Oct 7, 2022
@amtoine
Copy link
Owner Author

amtoine commented Oct 29, 2022

in order to address this, i would need some help @atxr 😕

@amtoine
Copy link
Owner Author

amtoine commented Oct 30, 2022

i came up with the following possible renaming table 😋

🔴 did not find a new name
🟡 not really happy with the new name
🟢 pretty happy with the new name

old new status
amtoine-apply-to-hunks goat-apply-to-hunks 🔴
amtoine-battery gbat 🟢
amtoine-compute-color-palette goat-compute-color-palette 🔴
amtoine-countdown goat-countdown 🔴
amtoine-dmrun gmrun 🟢
amtoine-gh-notify gghn 🟢
amtoine-hdmi grandr 🟢
amtoine-lcfg goat-lcfg 🔴
amtoine-lfrun glf 🟢
amtoine-list-monitors glm 🟢
amtoine-macho gmacho 🟡
amtoine-mocp gmocp 🟢
amtoine-open gopen 🟢
amtoine-pcm gpcm 🟡
amtoine-pdf gpdf 🟢
amtoine-pedit gedit 🟢
amtoine-prompt gask 🟢
amtoine-scrot gshot 🟢
amtoine-slock glock 🟢
amtoine-sound gmixer 🟢
amtoine-spark gspark 🟢
amtoine-surf-open gsurf 🟢
amtoine-sys-stats gsstats 🟢
amtoine-syssync gssync 🟢
amtoine-tcfg goat-tcfg 🔴
amtoine-time-date gdate 🟢
amtoine-togkb gtogkb 🟡
amtoine-tr2md gtr2md 🟡
amtoine-update gsupdate 🟢
amtoine-upl gpkg 🟢
amtoine-vdl gvdl 🟡
amtoine-weather-get gweather 🟡
amtoine-wfzf gwfzf 🟡
amtoine-wtldr gwtldr 🟡
amtoine-wvenv gwvenv 🟡
amtoine-xal gxal 🟡
amtoine-xtcl gxtcl 🟡
amtoine-ytdl gytdl 🟡

@atxr
Copy link

atxr commented Nov 15, 2022

Mmmm I tried to read the docs of those I didn't know and which were marked 🔴, but I have no other names to propose.
I think those are perfect!

@amtoine
Copy link
Owner Author

amtoine commented Nov 15, 2022

Mmmm I tried to read the docs of those I didn't know and which were marked red_circle, but I have no other names to propose. I think those are perfect!

me neither 👀

i think we'll stick with this list for now and i'll propose a PR asap 👍

@amtoine amtoine added the needs-triage An issue or a PR without label label Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed needs-triage An issue or a PR without label
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants