Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The headers are not correct anymore #2

Closed
amtoine opened this issue Jul 27, 2022 · 7 comments
Closed

The headers are not correct anymore #2

amtoine opened this issue Jul 27, 2022 · 7 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@amtoine
Copy link
Owner

amtoine commented Jul 27, 2022

Since i changed my username from a2n-s to amtoine, which i'm more happy with, the headers of most of the config files are not correct anymore!

Needed changes
i'll take the example of the amtoine-battery script in my scripts, see #18, which has the exact same problem.
the changes that should be applied:

diff --git a/scripts/amtoine-battery b/scripts/amtoine-battery
index 4642f77..beb2849 100755
--- a/scripts/amtoine-battery
+++ b/scripts/amtoine-battery
@@ -1,13 +1,13 @@
 #!/usr/bin/env bash
-#           ___
-#      __ _|_  )_ _ ___ ___   personal page: https://amtoine.github.io/
-#     / _` |/ /| ' \___(_-<   github   page: https://github.com/amtoine
-#     \__,_/___|_||_|  /__/   my   dotfiles: https://github.com/amtoine/dotfiles
-#           ___                _          _   _
-#      __ _|_  )_ _ ___ ______| |__  __ _| |_| |_ ___ _ _ _  _
-#     / _` |/ /| ' \___(_-<___| '_ \/ _` |  _|  _/ -_) '_| || |
-#     \__,_/___|_||_|  /__/   |_.__/\__,_|\__|\__\___|_|  \_, |
-#                                                         |__/
+#                _       _
+#      __ _ _ __| |_ ___(_)_ _  ___    personal page: https://amtoine.github.io/
+#     / _` | '  \  _/ _ \ | ' \/ -_)   github   page: https://github.com/amtoine
+#     \__,_|_|_|_\__\___/_|_||_\___|   my   dotfiles: https://github.com/amtoine/dotfiles
+#                _       _                  _          _   _
+#      __ _ _ __| |_ ___(_)_ _  ___   ___  | |__  __ _| |_| |_ ___ _ _ _  _
+#     / _` | '  \  _/ _ \ | ' \/ -_) |___| | '_ \/ _` |  _|  _/ -_) '_| || |
+#     \__,_|_|_|_\__\___/_|_||_\___|       |_.__/\__,_|\__|\__\___|_|  \_, |
+#                                                                      |__/
 #
 # Description:  a script to check the state of the battery and throw appropriate notifications.
 #   run `sudo systemctl enable cronie` to activate the `cron` daemon if not already done, then
@amtoine amtoine added the enhancement New feature or request label Jul 27, 2022
@amtoine amtoine self-assigned this Jul 27, 2022
@amtoine
Copy link
Owner Author

amtoine commented Oct 1, 2022

i've created this issue a while back when i changed my name from the old "a2n-s" to my new "amtoine" 🤔

what should we do from now on @atxr? 😋

@amtoine amtoine pinned this issue Oct 6, 2022
@amtoine
Copy link
Owner Author

amtoine commented Oct 6, 2022

i've tried to spot the files with bad headers, and here is the list, so far, of files whose headers will have to be addressed:

╭────┬──────────────────────────────────────────╮
│  0 │ .bash_aliases                            │
│  1 │ .bash_logout                             │
│  2 │ .bash_profile                            │
│  3 │ .bashrc                                  │
│  4 │ .config/X11/xinitrc                      │
│  5 │ .config/alacritty/alacritty.yml          │
│  6 │ .config/bspwm/bspwmrc                    │
│  7 │ .config/bspwm/scripts/autostart.sh       │
│  8 │ .config/bspwm/sxhkd/sxhkdrc              │
│  9 │ .config/dmenufm/dmenufm.conf             │
│ 10 │ .config/dmscripts/config                 │
│ 11 │ .config/git/config                       │
│ 12 │ .config/kitty/kitty.conf                 │
│ 13 │ .config/lazygit/config.yml               │
│ 14 │ .config/lf/lfrc                          │
│ 15 │ .config/lf/scripts/cleaner.sh            │
│ 16 │ .config/lf/scripts/previewer.sh          │
│ 17 │ .config/mpd/mpd.conf                     │
│ 18 │ .config/mpv/input.conf                   │
│ 19 │ .config/mpv/mplayer-input.conf           │
│ 20 │ .config/mpv/mpv.conf                     │
│ 21 │ .config/mpv/restore-old-bindings.conf    │
│ 22 │ .config/ncmpcpp/config                   │
│ 23 │ .config/neofetch/config.conf             │
│ 24 │ .config/neofetch/neofetchrc              │
│ 25 │ .config/qtile/bar.py                     │
│ 26 │ .config/qtile/config.py                  │
│ 27 │ .config/qtile/groups.py                  │
│ 28 │ .config/qtile/keys.py                    │
│ 29 │ .config/qtile/layouts.py                 │
│ 30 │ .config/qtile/mouse.py                   │
│ 31 │ .config/qtile/popups.py                  │
│ 32 │ .config/qtile/screens.py                 │
│ 33 │ .config/qtile/scripts/autostart.sh       │
│ 34 │ .config/qtile/scripts/bar.sh             │
│ 35 │ .config/qtile/scripts/km.sh              │
│ 36 │ .config/qtile/style.py                   │
│ 37 │ .config/qtile/utils/utils.py             │
│ 38 │ .config/qtile/widgets.py                 │
│ 39 │ .config/spectrwm/spectrwm.conf           │
│ 40 │ .config/spectrwm/spectrwm_fr.conf        │
│ 41 │ .config/spectrwm/spectrwm_us.conf        │
│ 42 │ .config/starship.toml                    │
│ 43 │ .config/surf/css/archlinux.css           │
│ 44 │ .config/surf/css/default.css             │
│ 45 │ .config/surf/css/github.css              │
│ 46 │ .config/surf/css/homepage.css            │
│ 47 │ .config/surf/css/kitty.css               │
│ 48 │ .config/surf/css/qtile.css               │
│ 49 │ .config/surf/css/sdd.css                 │
│ 50 │ .config/surf/css/stackoverflow.css       │
│ 51 │ .config/surf/css/suckless.css            │
│ 52 │ .config/surf/css/tecmint.css             │
│ 53 │ .config/surf/css/wikipedia.css           │
│ 54 │ .config/surf/css/youtube.css             │
│ 55 │ .config/surf/html/homepage.html          │
│ 56 │ .config/surf/scripts/add.bm.sh           │
│ 57 │ .config/surf/scripts/dmenu.linkselect.sh │
│ 58 │ .config/surf/scripts/dmenu.mpv.sh        │
│ 59 │ .config/surf/scripts/dmenu.setprop.sh    │
│ 60 │ .config/surf/scripts/dmenu.uri.sh        │
│ 61 │ .config/surf/scripts/edit.bookmarks.sh   │
│ 62 │ .config/surf/scripts/edit.screen.sh      │
│ 63 │ .config/surf/scripts/edit.url.sh         │
│ 64 │ .config/surf/scripts/link_hints.js       │
│ 65 │ .config/surf/scripts/open.help.sh        │
│ 66 │ .config/sxhkd/sxhkdrc                    │
│ 67 │ .config/tig/config                       │
│ 68 │ .config/tmux/tmux.conf                   │
│ 69 │ .config/vifm/vifmrc                      │
│ 70 │ .config/www/css/homepage.css             │
│ 71 │ .config/www/html/homepage.html           │
│ 72 │ .profile                                 │
╰────┴──────────────────────────────────────────╯

@amtoine amtoine added the help wanted Extra attention is needed label Oct 7, 2022
@atxr
Copy link
Contributor

atxr commented Oct 18, 2022

I think replacing every occurrence with goat for example can be better
It will allow us to make a separation between our personal config and the global goat config

@amtoine
Copy link
Owner Author

amtoine commented Oct 18, 2022

I think replacing every occurrence with goat for example can be better It will allow us to make a separation between our personal config and the global goat config

yup definitely 👍

but do you mean adding a new header to all the files?
with what content exactly?

@atxr
Copy link
Contributor

atxr commented Oct 19, 2022

Oh no I don't think it's necessary, that's a lot of work for nothing.
Just replacing the existing occurrences of amointe, ants...

@amtoine
Copy link
Owner Author

amtoine commented Oct 20, 2022

Oh no I don't think it's necessary, that's a lot of work for nothing. Just replacing the existing occurrences of amointe, ants...

mm 🤔
the thing is that the ASCII banners themselves are not correct anymore... 😕
so i think they should be replaced anyways

i've already tried to remove all the headers, and that's something totally feasible 👍
then the questions would be:

  • do we add another banner in replacement?
  • if yes, what do we add?

you know, something simple like

                _    __ _ _
 __ _ ___  __ _| |_ / _(_) |___ ___  GitHub: https://github.com/goatfiles
/ _` / _ \/ _` |  _|  _| | / -_|_-<  website: https://goatfiles.github.io
\__, \___/\__,_|\__|_| |_|_\___/__/  LICENSE: https://github.com/goatfiles/dotfiles/blob/main/LICENSE
|___/
            maintainers: 
                https://github.com/amtoine
                https://github.com/atxr 

you know, something nice and simple, easy to find, easy to edit, easy to replace and uniform accross all the dotfiles 🤔

in the end, i think all the old banners should go away, replaced or not 😉

@amtoine
Copy link
Owner Author

amtoine commented Nov 29, 2022

fixed in #22

@amtoine amtoine closed this as completed Nov 29, 2022
@amtoine amtoine unpinned this issue Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants