-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React based sample and AMP Validator #64
Comments
Yes - that's working as intended. The validator requires the root document to be AMPHTML. |
@sebastianbenz Do Google Search see AMP content in Shadow DOM? |
When the service-worker is not installed, the user will be served the AMP version of the page, which is correctly validated by the AMP validator: Once the service worker is installed, the request is caught by it and the app-shell is served. The app-shell itself is not an AMP page. It fetches the correspondent AMP page and uses the amp-shadow element to render it inside the shell. So, whenever a user-agent sees the page for the first time, the AMP version is served. The AMP version will also be served when the user-agent does not support service-workers. |
@andreban Service Worker is awesome. Thank you |
AMP Validator don't see AMP content in React based sample.
https://chrome.google.com/webstore/detail/amp-validator/nmoffdblmcmgeicmolmhobpoocbbmknc
The text was updated successfully, but these errors were encountered: