From 7ac93d67182213fbce745c8eefa7c3a0925dafbd Mon Sep 17 00:00:00 2001 From: Amandine Trolet Date: Mon, 22 Jul 2024 11:59:03 +0200 Subject: [PATCH 1/4] add validation for amp-social-share in amp-story --- .../validator-amp-story-amp-social-share.html | 101 ++++++++++++++++++ .../validator-amp-story-amp-social-share.out | 101 ++++++++++++++++++ .../amp-story/validator-amp-story.protoascii | 1 + 3 files changed, 203 insertions(+) create mode 100644 extensions/amp-story/1.0/test/validator-amp-story-amp-social-share.html create mode 100644 extensions/amp-story/1.0/test/validator-amp-story-amp-social-share.out diff --git a/extensions/amp-story/1.0/test/validator-amp-story-amp-social-share.html b/extensions/amp-story/1.0/test/validator-amp-story-amp-social-share.html new file mode 100644 index 000000000000..83d31be254f3 --- /dev/null +++ b/extensions/amp-story/1.0/test/validator-amp-story-amp-social-share.html @@ -0,0 +1,101 @@ + + + + + + + + + + My Story + + + + + + + + + + + +

Content

+ + + + + + diff --git a/extensions/amp-story/1.0/test/validator-amp-story-amp-social-share.out b/extensions/amp-story/1.0/test/validator-amp-story-amp-social-share.out new file mode 100644 index 000000000000..b725f0827513 --- /dev/null +++ b/extensions/amp-story/1.0/test/validator-amp-story-amp-social-share.out @@ -0,0 +1,101 @@ +PASS +| +| + + + + + + + My Story + + + + + + + + + + + +

Content

+ + + + + + diff --git a/extensions/amp-story/validator-amp-story.protoascii b/extensions/amp-story/validator-amp-story.protoascii index 2de6e5875f33..1869b771fc89 100644 --- a/extensions/amp-story/validator-amp-story.protoascii +++ b/extensions/amp-story/validator-amp-story.protoascii @@ -136,6 +136,7 @@ tags: { # child_tags: { child_tag_name_oneof: "AMP-ANALYTICS" child_tag_name_oneof: "AMP-PIXEL" + child_tag_name_oneof: "AMP-SOCIAL-SHARE" child_tag_name_oneof: "AMP-STORY-ANIMATION" child_tag_name_oneof: "AMP-STORY-AUTO-ANALYTICS" child_tag_name_oneof: "AMP-STORY-CTA-LAYER" From 334a997b4543567300909e0b52542df32093a0e2 Mon Sep 17 00:00:00 2001 From: Amandine Trolet Date: Thu, 25 Jul 2024 17:05:14 +0200 Subject: [PATCH 2/4] Add amp-story with amp-social-share example --- .../amp-story/amp-story-social-share.html | 120 ++++++++++++++++++ 1 file changed, 120 insertions(+) create mode 100644 examples/amp-story/amp-story-social-share.html diff --git a/examples/amp-story/amp-story-social-share.html b/examples/amp-story/amp-story-social-share.html new file mode 100644 index 000000000000..99317d6e5528 --- /dev/null +++ b/examples/amp-story/amp-story-social-share.html @@ -0,0 +1,120 @@ + + + + + + My Story with social share + + + + + + + + + + + + + + + + + + + + From b52ae253a50996746be6f6e2e5219ccb2c3fb89f Mon Sep 17 00:00:00 2001 From: Amandine Trolet Date: Fri, 26 Jul 2024 11:49:22 +0200 Subject: [PATCH 3/4] Update amp-story with amp-social-share example --- .../amp-story/amp-story-social-share.html | 78 ++++++++++++++++--- 1 file changed, 66 insertions(+), 12 deletions(-) diff --git a/examples/amp-story/amp-story-social-share.html b/examples/amp-story/amp-story-social-share.html index 99317d6e5528..4d7af5ddaaa8 100644 --- a/examples/amp-story/amp-story-social-share.html +++ b/examples/amp-story/amp-story-social-share.html @@ -67,33 +67,51 @@ } } -