Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up amp-app-banner bug warning in readme #8290

Closed
muxin opened this issue Mar 21, 2017 · 4 comments
Closed

Clean up amp-app-banner bug warning in readme #8290

muxin opened this issue Mar 21, 2017 · 4 comments
Assignees
@muxin
Milestone
Backlog Bugs

Comments

@muxin
Copy link
Contributor

muxin commented Mar 21, 2017 •
edited
Loading

Ensure the note ####(Dec. 15, 2016) Note: We have discovered an issue is removed from https://github.com/ampproject/amphtml/blob/master/extensions/amp-app-banner/amp-app-banner.md
@muxin muxin self-assigned this Mar 21, 2017
@muxin muxin added this to the Backlog Bugs milestone Mar 21, 2017
@muxin muxin changed the title Clean up experiment flag for viewer-support-app-banner-in-ios-embed Clean up amp-app-banner bug warning in readme Apr 4, 2017
@muxin muxin mentioned this issue Apr 4, 2017
Merged
@aghassemi
Copy link
Contributor

@muxin Could you please verify that iOS fix is live for amp-app-banner and update the doc if so?

@jridgewell
Copy link
Contributor

Ping. There's a message in Slack.

@muxin
Copy link
Contributor Author

muxin commented May 1, 2017

The bug for embedded ios is fixed. But I just found out that non-embed chrome ios is not working. #9077

@aghassemi
Copy link
Contributor

@muxin ok since the common case (Safari Ios embed) is fixed, I merged #8579

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muxin muxin

Labels
None yet
Projects
None yet
Milestone
Backlog Bugs
Development

No branches or pull requests
4 participants
@jridgewell @aghassemi @muxin @ampwafflebot