Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify 3p code path to build window.context from AmpContext #7604

Closed
bradfrizzell opened this issue Feb 16, 2017 · 3 comments
Closed

Modify 3p code path to build window.context from AmpContext #7604

bradfrizzell opened this issue Feb 16, 2017 · 3 comments
Assignees
@jasti @bradfrizzell
Labels
P2: Soon Type: Feature Request WG: monetization
Milestone
New FRs

Comments

@bradfrizzell
Copy link
Contributor

AmpContext class was added to provide window.context functionality to x-domained iframes. Need to eliminate unnecessary code duplication due to 3p still using stale code to create window.context
@bradfrizzell bradfrizzell self-assigned this Feb 16, 2017
@adelinamart adelinamart added this to the New FRs milestone Feb 23, 2017
This was referenced Feb 24, 2017
Closed
Closed
@bradfrizzell
Copy link
Contributor Author

I'm closing this as per #7841 unless that PR did not meet all the use cases. @lannka please confirm

@zhouyx
Copy link
Contributor

zhouyx commented Mar 13, 2017

@bradfrizzell any plan on using the new #serializeMessage function. Asking because #6873 is blocked by this. https://github.com/ampproject/amphtml/blob/master/src/iframe-helper.js#L360 current #postMessageToWindows doesn't contain rtv version number.

@lannka
Copy link
Contributor

lannka commented Mar 13, 2017

No worry, I will take care of the remaining stuff. As tracked separately here: #8087.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasti jasti

@bradfrizzell bradfrizzell

Labels
P2: Soon Type: Feature Request WG: monetization
Projects
None yet
Milestone
New FRs
Development

No branches or pull requests
5 participants
@jasti @bradfrizzell @zhouyx @lannka @adelinamart