Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Support "add to homescreen" banner/button for PWAs #6921

Open
ericlindley-g opened this issue Jan 6, 2017 · 10 comments
Open

FR: Support "add to homescreen" banner/button for PWAs #6921

ericlindley-g opened this issue Jan 6, 2017 · 10 comments

Comments

@ericlindley-g
Copy link
Contributor

ericlindley-g commented Jan 6, 2017

Tracking issue to extend <amp-app-banner> support to include promo for progressive web apps "add to homescreen" banner

@thomaspessato
Copy link

Looking forward to have this possibility 🛏

@odiego
Copy link

odiego commented Aug 21, 2017

Is this on the roadmap? It would be an awesome feature!

@ericlindley-g
Copy link
Contributor Author

We do really want to support this, @odiego — mostly a matter of finding time to do it :) @aghassemi, do you know if this is straightforward enough for a GFI?

@aghassemi
Copy link
Contributor

aghassemi commented Aug 21, 2017

hmm, I am not sure how this would work. Unless Chrome has decided that web app is worthy to be homscreenable, we can't prompt for add-to-homescreen AFAIK (this is different than amp-app-banner where we can just open a link to app store). If chrome has already decided the app is worthy, then service-worker has already ran and we are in PWA land and the app shell can handle this anyway.

Maybe I am missing something /cc @cvializ

@gui-poa
Copy link

gui-poa commented Aug 21, 2017

Chrome will never prompt, because the page is served from AMP Cache (vast majority). It is a Security issue.
"Manifest: property start_url ignored, should be same origin as document"

Maybe it's a Chrome issue. But, definetely, it would be a nice feature to improve AMP + PWA.

@cvializ
Copy link
Contributor

cvializ commented Aug 24, 2017

I am inclined to believe that more often than not, the add to homescreen banner will need to be triggered by the PWA shell and not the AMP document. Like @gui-poa stated, the page will need to be served from the document origin and not the AMP cache for the banner to work. AMP install service worker can allow the app to switch to the PWA experience where the PWA can then implement the banner.

Maybe this issue could instead track the effort to add the banner to one of our PWA shell examples? @ericlindley-g @dvoytenko

@demianrenzulli
Copy link
Contributor

Hi team,

Televisa is using AMP as a framework for several properties (e.g. noticieros.televisa.com), and is interested on being able to track PWA metrics, like A2HS acceptance rate (as explained here for non-AMP sites).

Is there any chance to re-prioritize this feature, so that AMP-first sites can access to similar PWA capabilities than non-AMP websites?

Otherwise, can you think on a workaround for this?

cc // @HelaGone

@dvoytenko
Copy link
Contributor

/cc @nainar

@stale
Copy link

stale bot commented Dec 18, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added Stale Inactive for one year or more and removed Stale Inactive for one year or more labels Dec 18, 2021
@stale
Copy link

stale bot commented Dec 24, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests