Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I2I: Classify traffic for AdSense Ad Size Optimization #27712

Closed
Jiaming-X opened this issue Apr 12, 2020 · 5 comments
Closed

I2I: Classify traffic for AdSense Ad Size Optimization #27712

Jiaming-X opened this issue Apr 12, 2020 · 5 comments
Labels
INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code WG: monetization

Comments

@Jiaming-X
Copy link
Member

Jiaming-X commented Apr 12, 2020

Summary

In the earlier issue, we have implemented the logic for Adsense Ad Size Optimization. However, the width expansion would not work for some of the users with wide viewport since the expanded Ad could cover the contents in the nearby columns. To prevent broken user experience, we need to classify the traffic to decide whether to turn on the Ad Size Optimization or not.

Design document

Check out this Google doc for details and internal references.

Motivation

To prevent broken user experience, we need to classify the traffic to decide whether to turn on the Ad Size Optimization or not.

/cc @ampproject/wg-approvers, @charliereams

@Jiaming-X Jiaming-X added the INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code label Apr 12, 2020
@calebcordry
Copy link
Member

to/ @ampproject/wg-ads

@jamesozzie
Copy link

@Jiaming-X @calebcordry I'm happy to share some examples of sites using Auto ads for AMP which would be impacted by this. Easy to replicate, and I not sure it's specific to users with wide viewports.

@Jiaming-X
Copy link
Member Author

@jamesozzie Thanks James. Feel free to share it. I think there are a few flows would create the similar issues in the bug. The Formatopia(this one) is one of them. I might need to create another issue for the auto ad one.

@jamesozzie
Copy link

@Jiaming-X Sure, below are examples of some sites I've came across which I've noticed Auto ads for AMP placing adverts directly above the content.

Happy to provide further details if necessary, or recreate with test sites. All the above are WordPress sites.

@Jiaming-X
Copy link
Member Author

The issue was resolved. Closing the ticket now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code WG: monetization
Projects
None yet
Development

No branches or pull requests

3 participants