Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Review 2019-11-13 21:00 UTC (CCPA, AMP Story quizzes) #25082

Closed
mrjoro opened this issue Oct 16, 2019 · 10 comments
Closed

Design Review 2019-11-13 21:00 UTC (CCPA, AMP Story quizzes) #25082

mrjoro opened this issue Oct 16, 2019 · 10 comments
Assignees
Milestone

Comments

@mrjoro
Copy link
Member

mrjoro commented Oct 16, 2019

Time: 2019-11-13 21:00 UTC (add to Google Calendar)
Location: Video conference via Google Meet

The AMP community holds weekly engineering design reviews. We encourage everyone in the community to participate in these design reviews.

If you are interested in bringing your design to design review, read the design review documentation and add a link to your design doc or issue by the Monday before your design review.

When attending a design review please read through the designs before the design review starts. This allows us to spend more time on discussion of the design.

We rotate our design review between times that work better for different parts of the world as described in our design review documentation, but you are welcome to attend any design review. If you cannot make any of the design reviews but have a design to discuss please let mrjoro@ know on Slack and we will find a time that works for you.

@mrjoro mrjoro added this to the Docs Updates milestone Oct 16, 2019
@mrjoro mrjoro self-assigned this Oct 16, 2019
@mrjoro
Copy link
Member Author

mrjoro commented Oct 16, 2019

The Ads Working Group and Access & Subscriptions Working Group will be presenting their periodic updates at this Design Review (10-15 minutes).

/cc @ampproject/wg-ads @lannka @ampproject/wg-access-subscriptions @jpettitt

---- Edit -----
wg-ads update
wg-access-subscriptions update

@jackbsteinberg
Copy link
Contributor

jackbsteinberg commented Nov 6, 2019

I'd like to discuss the design for the AMP Story Quiz component: STAMP Quizzes Design Doc Link

@rsimha
Copy link
Contributor

rsimha commented Nov 12, 2019

I'd like to discuss I2I: Rename AMP's release flavors

@rcebulko
Copy link
Contributor

rcebulko commented Nov 12, 2019

If there's time, I'd like to discuss a monthly AMP release cadence (#25578), and whether or not a monthly release candidate is necessary.

@zhouyx
Copy link
Contributor

zhouyx commented Nov 12, 2019

I'd also like to discuss the amp-consent design for CCPA. #24910

@mrjoro
Copy link
Member Author

mrjoro commented Nov 13, 2019

CCPA

  • is this proposal only for things being served from the cache / viewers?
      - no, it needs to support different scenarios, including publishers
      - wapo: we can handle serving different versions of the AMP page in California, but not every publisher could do that
      - we need to think about signed exchanges as well; signed exchanges wouldn't be able to do server-side calculations to server different pages
  • could we serve different versions from the Google AMP Cache?
      - no; that's too much work
      - there will likely be many different consent policies in the future
  • iframe solution (proposal Add commit hooks #1)
      - it would be costly for publishers to implement
      - we do this for access today; not simple to build, can cause issues with regressions
      - a lot of the business logic is already there on the server, this is just a set of APIs for how they present it
      - could be an issue for smaller publishers; need to set up an iframe and host it somewhere; likely a "consent management platform" for smaller publishers in the future
  • could we allow scoping to a geographic locale without needing amp-script?
      - @dvoytenko: this definitely seems possible
      - wapo would need the consent string even outside of California to send to vendors to ensure (IAB); AMP can't provide the consent string; we pass them but don't interpret them, vendor needs to understand them
      - initial implementation: one consent string for CA (geofenced), one for GDPR (geofenced), one for "this is not relevant"
  • performance for proposal Add commit hooks #1 and cost for publisher are biggest concerns
  • can we have a simple configuration for smaller publishers?  e.g. "in California, don't give consent"
      - we don't have time to detect if they are in California by MVP
      - a lot of of publishers are moving to consent management platforms where they drop a widget on the page; that puts the experience in the page; this could be provided in an iframe
      - could we provide amp-consent- for these consent management platforms?  we will welcome this, but unlikely in necessary time frame
  • can server list the consents the user needs to engage with, rather than the server storing what the user has chosen?  (it wouldn't require a user id)
      - this is part of proposal 2; endpoint would return with whether the consent is required (endpoint is an external service)
  • with code freeze, when will we have it ready?
      - goal is to have AMP implementation in canary by December 1 Edit: we will target having the CCPA implementation in the December 3 canary

@mrjoro
Copy link
Member Author

mrjoro commented Nov 13, 2019

Quizzes

  • @mrjoro - we should make sure the backend is configurable at launch with a documented API, not require a Google Reactions backend
      - or should this be amp-quiz-google, where it is a Google specific component?  we want this to be more generic
      - there's a video interface, everyone implements their interface
  • feels weird that we have a special stories quiz component without having a generic quiz component?
      - do we have other examples of this?  some, like amp-consent, since stories is opinionated about UI
      - story quizzes would be very opinionated, general amp-quiz would be very customizable
      - is there a plan for an amp quiz component?  not right now
  • abuse prevention?
  • format
      - we can't validate the content of the JSON configuration; we can validate there's a script tag
      - does it require a correct option?  yes for now; there will be a separate poll component that won't
  • why are we using shadow dom? style scoping
      - should we iframe it?  not clear it has advantages
      - does it seem like an integral part of the page or something embedded on the page
  • how does internationalization work with A/B/C/D options?  we need to figure this out
  • does the customization options of the objects use the json object?  they'd be attributes

@mrjoro
Copy link
Member Author

mrjoro commented Nov 13, 2019

We didn't get time to talk about AMP's release flavor names or monthly AMP release cadence. Those conversations will happen offline; see the linked issues for details.

@mrjoro mrjoro closed this as completed Nov 13, 2019
@mrjoro mrjoro changed the title Design Review 2019-11-13 21:00 UTC (Americas) Design Review 2019-11-13 21:00 UTC (CCPA, AMP Story quizzes) Nov 13, 2019
@mrjoro
Copy link
Member Author

mrjoro commented Nov 14, 2019

Minor update on CCPA: we will be targeting the December 3 canary as that is the normal Canary release date (rather than December 1).

@rsimha
Copy link
Contributor

rsimha commented Nov 15, 2019

We didn't get time to talk about AMP's release flavor names...

After going through comments on the design doc and discussing with @cramforce, the original I2I has been updated with the list of release flavor names.

Copy-pasting here. Names that are changing are italicized.

Current name New name
prod stable
rc beta
canary experimental
control control
nightly nightly
monthly lts
experimentA experimentA
experimentB experimentB
experimentC experimentC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants