Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[amp-script] AMP.setState() should trigger amp-bind script evaluation #24950

Closed
sebastianbenz opened this issue Oct 8, 2019 · 1 comment
Closed

[amp-script] AMP.setState() should trigger amp-bind script evaluation #24950

sebastianbenz opened this issue Oct 8, 2019 · 1 comment
Assignees
@dreamofabear
Labels
Type: Feature Request

Comments

@sebastianbenz
Copy link
Contributor

Currently, calling AMP.setState({}) from within amp-script won't execute bindings. We should at least allow this if the AMP.setState call was initiated by an user interaction.

My use case is: open a search dialog via a keyboard shortcut.

Demo: https://amp-script-demos.glitch.me/#development=1
@dreamofabear
Copy link

Thanks for the FR. Deduping with #24862.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreamofabear dreamofabear

Labels
Type: Feature Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebastianbenz @dreamofabear