Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMP-to-AMP (A2A) linking #12496

Closed
2 tasks done
dreamofabear opened this issue Dec 18, 2017 · 9 comments · Fixed by #13300
Closed
2 tasks done

AMP-to-AMP (A2A) linking #12496

dreamofabear opened this issue Dec 18, 2017 · 9 comments · Fixed by #13300
Assignees
@dreamofabear
Labels
P1: High Priority Type: Feature Request WG: runtime
Milestone
Sprint H1 February

Comments

@dreamofabear
Copy link

dreamofabear commented Dec 18, 2017 •
edited
Loading

Features for publishers to specify navigation from an AMP page to another AMP page when served from CDN:

  • Add per-link opt-in, e.g. <a href="example.com/amp" amp>
  • Add whole page opt-in for all navigation features (links, AMP.navigateTo, AMP-Redirect-To) with new boolean attribute on HTML tag e.g. <html a2a-by-default>

Notes:

  • The viewer already has an a2a capability and page -> viewer message. See navigateTo() in viewer-impl.js
  • Note that this is distinct from the proposed AMP Cache transformation that adds amp-href to normal <a> URLs that it already has a cached AMP page for

/cc @lswang1618
@dreamofabear dreamofabear added this to the Prioritized FRs milestone Dec 18, 2017
@dreamofabear dreamofabear self-assigned this Dec 18, 2017
@lswang1618
Copy link

Just confirming, does per-link opt in only include anchor links or is it for all navigation features?

@ithinkihaveacat
Copy link
Contributor

Does this have the same behavior on and off caches?

@morsssss
Copy link
Contributor

Nice!

@dreamofabear
Copy link
Author

@lswang1618 All navigation features eventually, <a> first.

@ithinkihaveacat Good question. Off cache this is a no-op.

@ampprojectbot
Copy link
Member

This is a high priority issue but it hasn't been updated in awhile. @choumx Do you have any updates?

@aghassemi aghassemi mentioned this issue Jan 24, 2018
Closed
This was referenced Jan 24, 2018
Closed
Closed
@dreamofabear
Copy link
Author

Feedback from design review #12939 (comment):

  • Use <a rel="amphtml"> instead of new boolean attribute?
  • Don't proliferate "a2a" acronym
  • For now, don't publicize document-level opt-in in case we iterate on the syntax

@dreamofabear
Copy link
Author

dreamofabear commented Feb 5, 2018 •
edited
Loading

New proposal

For links:

<a rel=amphtml href="amp.html">An AMP link</a>

For forms and actions:

<!-- Per-feature opt-in based on `content` attribute. -->
<meta name="amp-to-amp-navigation" content="AMP-Redirect-To; AMP.navigateTo">

/cc @cramforce

@cramforce
Copy link
Member

Looks good as discussed in review. No semiconolon in content.

@dreamofabear dreamofabear mentioned this issue Feb 6, 2018
Merged
@newmuis newmuis mentioned this issue May 12, 2018
Merged
@Enriqe Enriqe mentioned this issue May 14, 2018
Closed
@westonruter westonruter mentioned this issue Sep 2, 2018
Closed
@westonruter
Copy link
Member

FYI: I've put together an extension that implements A2A linking for sites using the AMP plugin, when that feature is implemented by an AMP viewer. See more at ampproject/amp-wp#1389 (comment).

@westonruter westonruter mentioned this issue Dec 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreamofabear dreamofabear

Labels
P1: High Priority Type: Feature Request WG: runtime
Projects
None yet
Milestone
Sprint H1 February
Development

Successfully merging a pull request may close this issue.

Implement A2A support dreamofabear/amphtml
8 participants
@ithinkihaveacat @cramforce @westonruter @danielrozenberg @lswang1618 @dreamofabear @ampprojectbot @morsssss