Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refines handling of 0 and unset height/width attrs #978

Closed
wants to merge 3 commits into from
Closed

Refines handling of 0 and unset height/width attrs #978

wants to merge 3 commits into from

Conversation

davisshaver
Copy link
Contributor

@davisshaver davisshaver commented Feb 26, 2018 •
edited
Loading

See #974

@davisshaver
Copy link
Contributor Author

davisshaver commented Feb 26, 2018 •
edited
Loading

CI shows some warnings due to => spacing in the update test file, however based on the existing spacing I think we want to ignore these. See how => do not align in current https://github.com/Automattic/amp-wp/blob/develop/tests/test-amp-img-sanitizer.php#L15

@davisshaver davisshaver mentioned this pull request Feb 26, 2018
Merged
kienstra pushed a commit that referenced this pull request Mar 1, 2018
Merge in develop, resolve conflicts.
c5c46ac 
Many conflicts were trivial,
and I retained both edits.
But there were 'sizes' attributes in:
test-amp-img-sanitizer.php.
These are from PR #978,
and it looks like they were just added
in order for the tests of images to pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davisshaver