Fix for AMP height & width invalid attributes #695
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes invalid layout properties specifically with an empty value for height or width attributes.
|
Agreeing with @luigitec - #693 (comment), the unit tests do need to be updated. |
westonruter
reviewed
Oct 26, 2017
| if ( $new_attributes['height'] === '' ) { | ||
| $new_attributes['height'] = self::FALLBACK_HEIGHT; | ||
| } | ||
| if ( $new_attributes['width'] === '' ) { |
There was a problem hiding this comment.
Instead of strict equality with an empty string, perhaps empty() just in case the value is null or false.
|
See also #575. |
|
I believe this was fixed with #979. Please let me know if otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, there are dimensions for height and not the width and vice-versa. This leaves one attribute with no value which results as an invalid layout property. With this, now it will use the dimension for the given attribute and for the other dimension that wasn't given, it will use the default dimension.