Display SUMMARY marker by preventing inline display #6118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin builds for e25ceba are ready 🛎️!
|
westonruter
reviewed
Apr 26, 2021
| @@ -413,7 +413,6 @@ li.error-kept { | |||
| } | |||
|
|
|||
| #paired-url-structure .amp-paired-url-examples summary { | |||
| display: inline-block; | |||
There was a problem hiding this comment.
Humm. I had added this 5 months ago for some reason: 7354ccf
There was a problem hiding this comment.
This behavior of the summary element is quite odd to me and I wasn't aware of it before. But it seems it's a known limitation/quirk (see the last paragraph).
westonruter
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The "Examples" elements in the Paired URL Structure sections on the Settings page were missing the expander arrows.
It was caused by the fact that the
summaryelementdisplayvalue has been changed from the default value (list-item) toinline-block.Checklist