Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for v2.1 #6110

Merged
merged 10 commits into from
May 6, 2021
Merged

Update README for v2.1 #6110

merged 10 commits into from
May 6, 2021

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Apr 23, 2021

Summary

With the advent of Page Experience as being the focus of what the AMP plugin delivers, we should update the plugin's metadata to reflect this. In particular, instead of the AMP plugin “The Official AMP Plugin” (which doesn't really say much) we can indicate that it is the “fastest” way to achieve good page experience on a site.

  • Update contributors
  • Adjust tags (perhaps replacing official with page experience, and remove many others)
  • Update tagline
  • Update description
  • Update banner image
  • Update plugin description on amp.php

For the tags, only the first 5 are shown:

image

However, we currently have 11: amp, mobile, optimization, accelerated mobile pages, framework, components, blocks, performance, ux, seo, official.

We can eliminate many of these.

Directory page

Before After
image image

Directory Listing

Before Search Before Listing After
image image image

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@westonruter westonruter added this to the v2.1 milestone Apr 23, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2021

Plugin builds for 3ebc076 are ready 🛎️!

@CLAassistant
Copy link

CLAassistant commented Apr 27, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #6110 (3ebc076) into develop (cf7b2b3) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #6110      +/-   ##
=============================================
+ Coverage      75.03%   75.11%   +0.08%     
- Complexity      5829     5859      +30     
=============================================
  Files            232      234       +2     
  Lines          17618    17713      +95     
=============================================
+ Hits           13219    13306      +87     
- Misses          4399     4407       +8     
Flag Coverage Δ Complexity Δ
javascript 79.84% <ø> (ø) 0.00 <ø> (ø)
php 74.90% <ø> (+0.09%) 5859.00 <ø> (+30.00)
unit 74.90% <ø> (?) 5859.00 <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
amp.php 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ludes/embeds/class-amp-instagram-embed-handler.php 38.66% <0.00%> (-3.99%) 26.00% <0.00%> (+1.00%) ⬇️
src/Admin/ValidationCounts.php 33.33% <0.00%> (-1.67%) 4.00% <0.00%> (ø%)
includes/options/class-amp-options-manager.php 91.93% <0.00%> (-0.89%) 71.00% <0.00%> (-4.00%)
src/Admin/OnboardingWizardSubmenuPage.php 82.10% <0.00%> (-0.37%) 21.00% <0.00%> (ø%)
src/AmpWpPlugin.php 100.00% <0.00%> (ø) 9.00% <0.00%> (ø%)
src/Admin/Polyfills.php 23.72% <0.00%> (ø) 12.00% <0.00%> (ø%)
src/Cli/OptimizerCommand.php 0.00% <0.00%> (ø) 9.00% <0.00%> (ø%)
src/Cli/TransformerCommand.php 0.00% <0.00%> (ø) 29.00% <0.00%> (-2.00%)
src/Optimizer/AmpWPConfiguration.php 100.00% <0.00%> (ø) 5.00% <0.00%> (ø%)
... and 13 more

Copy link
Member Author

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update the plugin description:

This official plugin from the AMP project enables AMP content publishing with WordPress in a way that is fully and seamlessly integrated with the standard mechanisms of the platform.

This is what is shown in the directory list:

image

It appears it needs to be 15 words or less.

README.md Outdated Show resolved Hide resolved
amp.php Outdated Show resolved Hide resolved
amedina and others added 2 commits May 6, 2021 08:22
Co-authored-by: Weston Ruter <[email protected]>
Co-authored-by: Weston Ruter <[email protected]>
@amedina amedina requested review from pierlon and amedina and removed request for amedina May 6, 2021 15:23
README.md Outdated
@@ -2,10 +2,10 @@

![Banner](.wordpress-org/banner-1544x500.png)

The official AMP Plugin, supported by the AMP team. Formerly Accelerated Mobile Pages, AMP enables great experiences across both mobile and desktop.
[Page Experience](https://developers.google.com/search/docs/guides/page-experience) (PX) is a set of ranking signals—including [Core Web Vitals](https://web.dev/vitals/#core-web-vitals) (CWV)—measuring the user experience of interacting with a web page. AMP is a powerful and cost-effective tool enabling many optimizations and best practices automatically on your site, and making it easier for you to achieve good page experience. The official AMP Plugin, supported by the AMP team, makes it easy to bring the power of AMP to your WordPress site.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, according to the WP readme.txt spec, this can be a maximum of 150 characters and it cannot contain links.

In reality, the restriction seems to be even tighter than that. Only the first 15 words are displayed when browsing plugins:

Listing

So most of this needs to be moved down under ## Description.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be reduced to just this:

Suggested change
[Page Experience](https://developers.google.com/search/docs/guides/page-experience) (PX) is a set of ranking signals—including [Core Web Vitals](https://web.dev/vitals/#core-web-vitals) (CWV)—measuring the user experience of interacting with a web page. AMP is a powerful and cost-effective tool enabling many optimizations and best practices automatically on your site, and making it easier for you to achieve good page experience. The official AMP Plugin, supported by the AMP team, makes it easy to bring the power of AMP to your WordPress site.
An easier path to great Page Experience for everyone. Powered by AMP.

This is 12 words.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied this in 7aac832.

Copy link
Member

@amedina amedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@westonruter westonruter enabled auto-merge May 6, 2021 18:12
@westonruter westonruter merged commit 5001698 into develop May 6, 2021
@westonruter westonruter deleted the update/readme-2.1 branch May 6, 2021 18:13
westonruter added a commit that referenced this pull request May 6, 2021
Co-authored-by: Alberto A. Medina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants