Turn the AMP Optimizer into an injectable service

[schlessera]

Summary

This PR turns the AMP Optimizer into an injectable service and uses the injector configuration to configure it from a central location.

It also hooks the WordPress filters into the Optimizer's configuration object.

Fixes #6064
Depends on ampproject/amp-toolbox-php#150

Checklist

• My code is tested and passes existing tests.
• My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

[codecov]

Codecov Report

Merging #6065 (af79fa2) into develop (6b1af52) will increase coverage by 0.05%.
The diff coverage is 96.03%.

❗ Current head af79fa2 differs from pull request most recent head 70dced8. Consider uploading reports for the commit 70dced8 to get more accurate results

@@              Coverage Diff              @@
##             develop    #6065      +/-   ##
=============================================
+ Coverage      75.38%   75.44%   +0.05%     
- Complexity      5706     5714       +8     
=============================================
  Files            218      227       +9     
  Lines          17265    17335      +70     
=============================================
+ Hits           13016    13079      +63     
- Misses          4249     4256       +7     

Flag	Coverage Δ	Complexity Δ
javascript	79.84% <94.82%> (-0.22%)	0.00 <0.00> (ø)
php	75.24% <97.67%> (+0.05%)	0.00 <11.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
...lidation/components/amp-validation-status/index.js	0.00% <0.00%> (ø)	0.00 <0.00> (?)
...alidation/components/sidebar-notification/index.js	100.00% <ø> (ø)	0.00 <0.00> (ø)
...s/src/block-validation/components/sidebar/index.js	0.00% <ø> (ø)	0.00 <0.00> (?)
...udes/sanitizers/class-amp-core-theme-sanitizer.php	36.28% <ø> (ø)	228.00 <0.00> (ø)
src/Optimizer/Transformer/AmpSchemaOrgMetadata.php	85.71% <ø> (ø)	4.00 <0.00> (?)
.../Transformer/AmpSchemaOrgMetadataConfiguration.php	0.00% <ø> (ø)	4.00 <0.00> (?)
src/Optimizer/Transformer/DetermineHeroImages.php	91.04% <ø> (ø)	25.00 <0.00> (?)
...k-validation/hooks/use-post-dirty-state-changes.js	96.96% <75.00%> (-3.04%)	0.00 <0.00> (ø)
.../block-validation/hooks/use-amp-document-toggle.js	80.00% <80.00%> (ø)	0.00 <0.00> (?)
includes/class-amp-theme-support.php	86.19% <83.33%> (-0.03%)	244.00 <2.00> (-1.00)
... and 23 more

[github-actions]

Plugin builds for 70dced8 are ready 🛎️!

• Download development build
• Download production build

[westonruter]

Looks good, other than the test coverage complaints.

[westonruter]

Any chance this would be undesirable? What if you wanted to change the configuration with a filter change on a subsequent call?

[schlessera]

The alternative is to run the filters on every get() and has(), which can quickly become a performance issue.

If you want to change the configuration with a later filter call, you can instantiate a new configuration object instead.

Also, this should actually only be triggered when the optimizer is being run, which happens in the shutdown hook that collects the final output buffer after WordPress has finished. I don't think plugins should do anything after the optimizer has run.