Update amphtml spec to 1bbd5505 #5998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #5998 +/- ##
=============================================
- Coverage 80.05% 75.26% -4.80%
- Complexity 0 5703 +5703
=============================================
Files 41 218 +177
Lines 702 17275 +16573
=============================================
+ Hits 562 13002 +12440
- Misses 140 4273 +4133
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Plugin builds for bca8eb7 are ready 🛎️!
|
westonruter
force-pushed
the
update/amphtml-1bbd5505985
branch
from
e0de3b2
to
7efd17f
Compare
pierlon
reviewed
Mar 20, 2021
| @@ -637,6 +654,18 @@ static function () { | |||
| [ 'amp-story-player' ], | |||
| ], | |||
|
|
|||
| 'amp_google_assistant_assistjs' => [ | |||
| // Note: the first line is commented out because it is broken in AMP currently. | |||
There was a problem hiding this comment.
I suppose the only time this will be uncommented is when there is a future spec update that adds support for amp-google-assistant-assistjs-config > script.
Co-authored-by: Pierre Gordon <[email protected]>
pierlon
approved these changes
Mar 20, 2021
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously #5703.
./bin/amphtml-update.sh(lando ssh -c 'bash ./bin/amphtml-update.sh vendor/amphtml').validator-svg.protoasciiwhen collecting spec data as was done previously when rules were splug out intovalidator-css.protoascii.img[data-amp-story-player-poster-img].Changelog
@-moz-document url-prefix()Firefox CSS hack into@supports (-moz-appearance:meterbar). Fixes Eliminate obsolete transformation of@-moz-document url-prefix()Firefox CSS hack into@supports (-moz-appearance:meterbar)#5801.amp-story-auto-analyticscomponent. This is needed by Replace amp-story-bookend with amp-story-social-share GoogleForCreators/web-stories-wp#6852 (comment).amp-story-social-sharecomponent.amp-google-assistant-assistjs-configcomponent.amp-google-assistant-inline-suggestion-barcomponent.amp-google-assistant-voice-barcomponent.amp-google-assistant-voice-buttoncomponent.amp-adandamp-embed:always-serve-npaandblock-rtc.amp-base-carousel:controls.amp-bodymovin-animation: allowcanvas/svgvalues forrenderer.amp-story-grid-layer:anchor,preset.amp-story-page-attachment:cta-image,cta-image-2.feblend,fecomponenttransfer,feconvolvematrix,fediffuselighting,fedisplacementmap,fedistantlight,fedropshadow,fefunca,fefuncb,fefuncg,fefuncr,femorphology,fepointlight,fespecularlighting,fespotlight,fetile,feturbulence.img[data-amp-story-player-poster-img]as child ofamp-story-poster. Note that validity for this is currently broken by the Optimizer, to be fixed by Prevent loading=lazy attribute from being removed from amp-story-player poster img amp-toolbox-php#106.modulepreloadtolink[rel].kitsubdomain forfontawesome.comfont stylesheet URLs.script[amp-onerror]. See also Add support for script amp-onerror amp-toolbox-php#83.posterrequirement foramp-video-frame. See ✅ amp-video-iframe: Remove poster requirement amphtml#33088.Details
( PREV_VERSION=68e4db07; THIS_VERSION=1bbd5505; git checkout $THIS_VERSION; git diff $PREV_VERSION...$THIS_VERSION -w -- $( git ls-files | grep '.protoascii' ); git checkout - > /dev/null )68e4db07...1bbd5505