Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use just 'AMP' as plugin sidebar title instead of 'AMP for WordPress' #5870

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Feb 11, 2021

Summary

The title “AMP for WordPress” is excessively verbose for the plugin title in the block editor. It's obviously for WordPress since it is inside WordPress. So it should be simplified to just “AMP”:

Before After
Screen Shot 2021-02-11 at 15 36 09 Screen Shot 2021-02-11 at 15 36 31
Screen Shot 2021-02-11 at 15 37 02 Screen Shot 2021-02-11 at 15 36 45

The onboarding wizard does say “Welcome to AMP for WordPress” but that's OK since it's introducing the experience of AMP inside of WordPress:

image

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@westonruter westonruter added the WS:Core Work stream for Plugin core label Feb 11, 2021
@westonruter westonruter added this to the v2.1 milestone Feb 11, 2021
@github-actions
Copy link
Contributor

Plugin builds for 304bb38 are ready 🛎️!

Copy link
Member

@amedina amedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Ship it.

@westonruter westonruter merged commit 55b88b8 into develop Feb 12, 2021
@westonruter westonruter deleted the update/plugin-title branch February 12, 2021 00:27
@westonruter
Copy link
Member Author

QA Passed

But note we later changed it to “AMP Validation”:

image

image

@westonruter westonruter self-assigned this Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WS:Core Work stream for Plugin core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants