Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @wordpress/scripts from 12.6.1 to 13.0.1 #5818

Merged

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Jan 28, 2021

Bumps @wordpress/scripts from 12.6.1 to 13.0.1.

Changelog

Sourced from @wordpress/scripts's changelog.

Unreleased

13.0.0 (2021-01-21)

Breaking Changes

  • Increase the minimum Node.js version to 12 (#27934).
  • The bundled jest dependency has been updated to the next major version ^26.6.3 (see Breaking Changes, #27956).
  • The bundled @wordpress/eslint-plugin dependency has been updated to the next major version ^8.0.0. There are new ESLint rules enabled in the recommended config used by lint-js command.
  • The bundled stylelint-config-wordpress dependency has been replaced with @wordpress/stylelint-config (#27810)[https://github-redirect.dependabot.com/Use @wordpress/stylelint-config in @wordpress/scripts WordPress/gutenberg#27810].
  • The bundled puppeteer-core (3.0.0) dependency has been upgraded to version 5.5.0. Puppeteer uses Chromium v88 instead of Chromium v71. See the full list of breaking changes of 4.0.0 and 5.0.0.

Enhancements

  • wordpress subfolder is no longer ignored when detecting files for testing, linting or formatting.
  • The bundled eslint dependency has been updated from requiring ^7.1.0 to requiring ^7.17.0 (#27965).
  • Make it possible to transpile .jsx files with build and start commands (#28002).
  • Add support for static assets (fonts and images) for build and start commands (#28043).

Bug Fix

  • Ensure that check-engines uses the same default version of Node.js and npm as this package (#28143).
  • Prevent translation function names from being mangled to ensure stings are extracted (#28231).

Internal

  • The bundled webpack-bundle-analyzer dependency has been updated from requiring ^3.6.1 to requiring ^4.2.0.
Commits
  • 63f8f83 chore(release): publish
  • b1acb2e chore(release): publish
  • bf838b5 Update changelog files
  • 3b6fd5a Merge changes published in the Gutenberg plugin "release/9.8" branch
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will not automatically merge this PR because it includes an out-of-range update to a development dependency.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jan 28, 2021
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/wordpress/scripts-13.0.1 branch from 9016d61 to 8ae888d Compare January 28, 2021 16:34
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/wordpress/scripts-13.0.1 branch from 8ae888d to e631ddb Compare January 28, 2021 16:42
@github-actions
Copy link
Contributor

Plugin builds for 8775ea4 are ready 🛎️!

@pierlon
Copy link
Contributor

pierlon commented Jan 28, 2021

@westonruter I'd like your approval on this since I made some edits here.

Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the build and I didn't see any issue. So changes seem successful!

@dependabot-preview dependabot-preview bot merged commit a7b3ba4 into develop Jan 28, 2021
@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/wordpress/scripts-13.0.1 branch January 28, 2021 18:15
@delawski
Copy link
Collaborator

delawski commented Feb 4, 2021

I've encountered an issue related to this change.

TIL: having npm-related issues, it's worth running npm ci (not npm install) and retry.


When I've run npm install and then npm run test:e2e I was got the following error:

Error: Cannot find module 'puppeteer'

Removing node_modules and re-running npm install didn't help.

Note that the package-lock.json got updated by npm install, too.

I then reverted the changes in package-lock.json and run the npm ci command. This time I got no errors when running the E2E tests.

Btw. when I ran npm ci without rolling-back the package-lock.json file, I encountered the same error. So it seems the issue lies in the package-lock.json file. The only significant change made in that file after running npm install is as follows:

-	"puppeteer": {
-		"version": "npm:[email protected]",
-		"resolved": "https://registry.npmjs.org/puppeteer-core/-/puppeteer-core-5.5.0.tgz",
-		"integrity": "sha512-tlA+1n+ziW/Db03hVV+bAecDKse8ihFRXYiEypBe9IlLRvOCzYFG6qrCMBYK34HO/Q/Ecjc+tvkHRAfLVH+NgQ==",
-		"dev": true,
-		"requires": {
-			"debug": "^4.1.0",
-			"devtools-protocol": "0.0.818844",
-			"extract-zip": "^2.0.0",
-			"https-proxy-agent": "^4.0.0",
-			"node-fetch": "^2.6.1",
-			"pkg-dir": "^4.2.0",
-			"progress": "^2.0.1",
-			"proxy-from-env": "^1.0.0",
-			"rimraf": "^3.0.2",
-			"tar-fs": "^2.0.0",
-			"unbzip2-stream": "^1.3.3",
-			"ws": "^7.2.3"
-		}
-	},
-	"rimraf": {
-		"version": "3.0.2",
-		"resolved": "https://registry.npmjs.org/rimraf/-/rimraf-3.0.2.tgz",
-		"integrity": "sha512-JZkJMZkAGFFPP2YqXZXPbMlMBgsxzE8ILs4lMIX/2o0L9UBw9O/Y3o6wFw/i9YLapcUJWwqbi3kdxIPdC62TIA==",
-		"dev": true,
-		"requires": {
-			"glob": "^7.1.3"
-		}
-	},
+	"puppeteer": {
+		"version": "npm:[email protected]",
+		"resolved": "https://registry.npmjs.org/puppeteer-core/-/puppeteer-core-5.5.0.tgz",
+		"integrity": "sha512-tlA+1n+ziW/Db03hVV+bAecDKse8ihFRXYiEypBe9IlLRvOCzYFG6qrCMBYK34HO/Q/Ecjc+tvkHRAfLVH+NgQ==",
+		"dev": true,
+		"requires": {
+			"debug": "^4.1.0",
+			"devtools-protocol": "0.0.818844",
+			"extract-zip": "^2.0.0",
+			"https-proxy-agent": "^4.0.0",
+			"node-fetch": "^2.6.1",
+			"pkg-dir": "^4.2.0",
+			"progress": "^2.0.1",
+			"proxy-from-env": "^1.0.0",
+			"rimraf": "^3.0.2",
+			"tar-fs": "^2.0.0",
+			"unbzip2-stream": "^1.3.3",
+			"ws": "^7.2.3"
+		},
+		"dependencies": {
+			"rimraf": {
+				"version": "3.0.2",
+				"resolved": "https://registry.npmjs.org/rimraf/-/rimraf-3.0.2.tgz",
+				"integrity": "sha512-JZkJMZkAGFFPP2YqXZXPbMlMBgsxzE8ILs4lMIX/2o0L9UBw9O/Y3o6wFw/i9YLapcUJWwqbi3kdxIPdC62TIA==",
+				"dev": true,
+				"requires": {
+					"glob": "^7.1.3"
+				}
+			}
+		}
+	},

I'm not sure why would it cause an issue with puppeteer, considering that rimraf is on dependency lists of many other packages. I'm also not convinced it's worth further drilling down into the issue.

@westonruter westonruter added this to the v2.1 milestone Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants