Update class-amp-img-sanitizer.php #575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If only one image dimension is set, the img sanitizer would ignore it and use the actual image sizes instead. This proposed change checks if only one dimension was set, and if so, calculates the other.
|
See also #695. |
|
@westonruter for some reason I'm not able to reply to the comment above so replying here. I haven't looked at this in quite a while, so I'm not sure. If I remember correctly the specific problem was when the attribute wasn't included, not that it was there and set to 0. Also, the proposed change suggested to auto calculate the missing attribute. If those cases are covered, I'm guessing it should be good! |
westonruter
requested changes
Apr 10, 2018
|
I'm pretty sure this has been fixed in 0.7.1 via #1117: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If only one image dimension is set, the img sanitizer would ignore it and use the actual image sizes instead. This proposed change checks if only one dimension was set, and if so, calculates the other.