Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve diff output for PHP files #5694

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Improve diff output for PHP files #5694

merged 1 commit into from
Dec 14, 2020

Conversation

westonruter
Copy link
Member

Summary

Copied from ampproject/amp-toolbox-php#48.

See https://www.git-scm.com/docs/gitattributes#_defining_a_custom_hunk_header.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@westonruter westonruter added the WS:Core Work stream for Plugin core label Dec 14, 2020
@github-actions
Copy link
Contributor

Plugin builds for df0ecde are ready 🛎️!

@westonruter westonruter added this to the v2.1 milestone Dec 14, 2020
@westonruter
Copy link
Member Author

Checks passed! 😅

@westonruter westonruter merged commit 8c6e630 into develop Dec 14, 2020
@westonruter westonruter deleted the add/gitattributes-php-custom-hunk-header branch December 14, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierlon pierlon pierlon approved these changes

Assignees
No one assigned
Labels
WS:Core Work stream for Plugin core
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@westonruter @pierlon