Remove apparently obsolete polldaddy subdomain oEmbed test #5654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Plugin builds for c5819d4 are ready 🛎️!
|
pierlon
approved these changes
Dec 4, 2020
There was a problem hiding this comment.
Verified that the subdomain rydk.polldaddy.com domain no longer works and is returning a 404:
> curl -I https://api.crowdsignal.com/oembed\?url\=https://rydk.polldaddy.com/s/test-survey
HTTP/2 404
server: nginx
date: Fri, 04 Dec 2020 04:35:50 GMT
content-type: text/html; charset=utf-8
vary: Accept-Encoding
content-language: en
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Polldaddy was rebranded to Crowdsignal, and it appears that the old subdomain URLs under polldaddy.com now no longer work. This PR removes the breaking external-http test case.
Checklist