Hide AMP Noloading toggle if block does not have specified setting #5574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin builds for 8a6d522 are ready 🛎️!
|
johnwatkins0
suggested changes
Nov 6, 2020
| * @param {Object} props Props. | ||
| * | ||
| * @return {ReactElement} Element. | ||
| */ | ||
| const AmpNoloadingToggle = ( props ) => { | ||
| const { attributes: { ampNoLoading }, setAttributes } = props; | ||
|
|
||
| if ( ! ampNoLoading ) { |
There was a problem hiding this comment.
Should this be:
Suggested change
| if ( ! ampNoLoading ) { | |
| if ( undefined === ampNoLoading ) { |
If it's just ! ampNoLoading, then the toggle will be hidden on existing blocks that have it set to false. And if an existing block has it set to true and it is toggled to false, the toggle will disappear. That's not what we intend, right?
There was a problem hiding this comment.
Yea that's true, nice catch. I've addressed that in b390973.
pierlon
force-pushed
the
enhancement/4555-deprecate-amp-noloading-setting
branch
from
8832470
to
b390973
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5574 +/- ##
=============================================
+ Coverage 73.62% 73.64% +0.02%
Complexity 5424 5424
=============================================
Files 187 187
Lines 16364 16366 +2
=============================================
+ Hits 12048 12053 +5
+ Misses 4316 4313 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnwatkins0
approved these changes
Dec 11, 2020
johnwatkins0
approved these changes
Dec 11, 2020
westonruter
requested changes
Dec 11, 2020
There was a problem hiding this comment.
As noted in #5573 (review), please add a deprecation notice that warns the feature will be removed.
westonruter
requested changes
Dec 13, 2020
| <span dangerouslySetInnerHTML={ { | ||
| __html: sprintf( | ||
| /* translators: placeholder is link to support forum. */ | ||
| __( 'The AMP Layout setting is deprecated and is slated for removal. Please <a href="%s" target="_blank" rel="noreferrer">report</a> if you need it.', 'amp' ), |
pierlon
force-pushed
the
enhancement/4555-deprecate-amp-noloading-setting
branch
from
d358e75
to
d8a4e0c
Compare
…nt/4555-deprecate-amp-noloading-setting * 'develop' of github.com:ampproject/amp-wp: Add a warning notice to setting Add force flag to rm on the productionVendorExcludedFilePatterns Bump ampproject/amp-toolbox from 0.1.0 to 0.1.1 Rename test file Test AmpLayoutControl Use stricter condition check Hide AMP Layout toggle if block does not have specified setting
westonruter
approved these changes
Dec 13, 2020
westonruter
deleted the
enhancement/4555-deprecate-amp-noloading-setting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4555
Checklist