Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore docs folder when code coverage is being processed #5334

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Ignore docs folder when code coverage is being processed #5334

merged 1 commit into from
Sep 4, 2020

Conversation

pierlon
Copy link
Contributor

@pierlon pierlon commented Sep 4, 2020

Summary

This PR ignores the docs folder when code coverage is run.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@google-cla google-cla bot added the cla: yes Signed the Google CLA label Sep 4, 2020
@pierlon pierlon self-assigned this Sep 4, 2020
@pierlon pierlon added the WS:Core Work stream for Plugin core label Sep 4, 2020
@pierlon pierlon added this to the v2.0.2 milestone Sep 4, 2020
@pierlon pierlon added the Documentation Documentation related tasks label Sep 4, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2020

Plugin builds for 6e67bca are ready 🛎️!

@westonruter westonruter merged commit fc013cb into develop Sep 4, 2020
@westonruter westonruter deleted the codecov-ignore-docs branch September 4, 2020 03:44
westonruter pushed a commit that referenced this pull request Sep 4, 2020
@pierlon @westonruter
Ignore docs folder (#5334)
37c0299
@pierlon
Copy link
Contributor Author

pierlon commented Sep 17, 2020

This PR unfortunately did not fix the issue as intended. This should instead be fixed by #5341, specifically by this line:

amp-wp/codecov.yml

Line 39 in 96607a4

- "/docs/**/*"

@pierlon
Copy link
Contributor Author

pierlon commented Sep 17, 2020

Moved to the Done column.

@westonruter westonruter modified the milestones: v2.0.2, v2.0.3, v2.1 Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

Assignees
No one assigned
Labels
cla: yes Signed the Google CLA Documentation Documentation related tasks WS:Core Work stream for Plugin core
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@pierlon @westonruter