Eliminate obsolete re-validation when switching template modes #5100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin builds for 5865b05 are ready 🛎️!
|
pierlon
approved these changes
Jul 27, 2020
westonruter
added
the
Changelogged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that we no longer show a success/failure message specific to when changing the template mode, the logic that does this should be removed, at least for now. At present this code primarily just serves to slow down the user's request to switch template modes. The success/error messages that are currently being added via
add_settings_error()are not being displayed.In the near future, most likely part of #4719 or #4795, we'll need to add a site compatibility component to switching template modes on the settings screen.
Checklist