Include text content of style element in validation error #3717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierlon
approved these changes
Nov 12, 2019
|
Let me re-clarify. In Standard mode if I add a Custom HTML block that has 50KB+ of CSS:
I will then get, as expected, the invalid markup kept by default:
If I go ahead and mark that as removed, and then add two other 50KB+
Then the other invalid markup is automatically marked as removed, even though in Standard mode it should have defaulted to kept:
This doesn't happen because the status of the validation error is being applied to the other validation errors since they all have the same attributes (since the What should actually have been the result, and what this PR does, is make the other two
|
westonruter
added a commit
that referenced
this pull request
Nov 12, 2019
* Include text content in validation error for invalid style elements * Improve presentation of text content in validation error
|
Verified in QA: |
westonruter
added a commit
that referenced
this pull request
Nov 13, 2019
…ve-duplicate-amp-scripts * 'develop' of github.com:ampproject/amp-wp: (66 commits) Improve display of validation errors for scripts (#3722) Conditionally run E2E tests (#3723) Tidy up validation error details (#3721) Add missing space after sentence (#3720) Default to the homepage instead of fetching the first AMP compatible post to customize (#3715) Include text content of style element in validation error (#3717) Fix summarizing error sources both parent theme and child theme (#3709) Exclude WordPress.PHP.DisallowShortTernary phpcs sniff Fix phpcs issues with date() and current_time() Exclude Generic.Arrays.DisallowShortArraySyntax from WordPress-Core Update dependency wp-coding-standards/wpcs to v2.2.0 Improve specificity of JS doc Fix identifying sources for validation errors coming child themes (#3708) Fix failing E2E tests (#3707) Remove amp_validate query var from Validated URL 'View' row action Re-factor get_html_attribute_pattern as match_element_attributes Quote variables added to regex pattern Replace incorrect usage of esc_url() with esc_url_raw() Remove empty alt attributes Add object-fit=contain to amp-youtube placeholder image ...
westonruter
added a commit
that referenced
this pull request
Nov 14, 2019
* tag '1.4.1': (26 commits) Bump 1.4.1 Update screenshots for 1.4.1 Fix expected image name after upstream change (#3749) Use length property instead of count() method on DOMNodeList (#3727) Improve display of validation errors for scripts (#3722) Conditionally run E2E tests (#3723) Tidy up validation error details (#3721) Bump 1.4.1-RC1 Default to the homepage instead of fetching the first AMP compatible post to customize (#3715) Add missing space after sentence (#3720) Include text content of style element in validation error (#3717) Use bitwise operator. Check if element is not in top toolbar. Fix user select for meta date and author Allow right click for meta blocks Fix summarizing error sources both parent theme and child theme (#3709) Fix identifying sources for validation errors coming child themes (#3708) Fix failing E2E tests (#3707) Remove amp_validate query var from Validated URL 'View' row action (#3706) Escape instances of unescapeed output in AMP settings screen code (#3703) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #2326 (comment) it was discovered that an excessive CSS validation error for one
styleelement will get conflated with validation error for anotherstyleelement, if thestyleelements don't vary in their attributes. This is because the text content of thestyleelement was not being included in the validation error attributes; this was unlike what is being done for inlinescriptelements. So this PR ensures that the validation errors are distinct for distinctstyleelements.This PR also improves the display of the text content by putting the contents in
codeelement, and putting it inside of adetailselement that has the byte count.Before
After
Checklist