Fix displaying warning in editor when there is kept invalid markup

[westonruter]

Summary

I discovered that the warning notices in the editor do not accurately reflect the scenario when there is one or more bit of invalid markup which is kept. The issue stems from the status not being included among the validationErrors which are stored.

I also realized that the the messages were not updated after the rebranding in #3630. Some of the code also could be simplified. (See #3545/#3350.)

Validation Error(s) Kept

Given a URL that has errors in all 4 validation states:

Before:

After:

Validation Errors Removed

Before:

After:

Checklist

• My pull request is addressing an open issue (please create one otherwise).
• My code is tested and passes existing tests.
• My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

[amedina]

Phew. Ship it!

[pierlon]

Nice catch @westonruter!

[westonruter]

Failing tests are due to E2E issue, unrelated to changes here.