Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix page crashing when duplicating immovable blocks #3593

Merged
merged 12 commits into from
Oct 23, 2019
Merged

Fix page crashing when duplicating immovable blocks #3593

merged 12 commits into from
Oct 23, 2019

Commits on Oct 22, 2019

  1. Add logic for removing 'illegal' immovable blocks.

    @miina
    miina committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    e82a1ac View commit details
    Browse the repository at this point in the history

  2. Add snackbar notice when a block gets removed.

    @miina
    miina committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    40fae40 View commit details
    Browse the repository at this point in the history

  3. Add count to snackbar message.

    @miina
    miina committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    58b22d6 View commit details
    Browse the repository at this point in the history

  4. Use the immovable blocks directly instead of using a function.

    @miina
    miina committed Oct 22, 2019
    1 Configuration menu
    Copy the full SHA
    0197f85 View commit details
    Browse the repository at this point in the history

  5. Update assets/src/stories-editor/blocks/amp-story-page/edit.js 

    Co-Authored-By: Morten Barklund <[email protected]>
    @miina @barklund
    miina and barklund committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    a22cd90 View commit details
    Browse the repository at this point in the history

  6. Use getBlockOrder once only

    @miina
    miina committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    d3e4b74 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'fix/3467-page_crash_on_duplicate' of github.com:ampproj… 

    …ect/amp-wp into fix/3467-page_crash_on_duplicate
    @miina
    miina committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    a3bece8 View commit details
    Browse the repository at this point in the history

  8. Fix slicing and remove pop()

    @miina
    miina committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    005d62e View commit details
    Browse the repository at this point in the history

  9. Remove redundant code.

    @miina
    miina committed Oct 22, 2019
    2 Configuration menu
    Copy the full SHA
    63850c9 View commit details
    Browse the repository at this point in the history

  10. Remove more redundant code.

    @miina
    miina committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    2eccdec View commit details
    Browse the repository at this point in the history

  11. Merge conflict.

    @miina
    miina committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    86d3216 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2019

  1. Slightly update wording

    @swissspidy
    swissspidy committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    f5d7b21 View commit details
    Browse the repository at this point in the history