Improve handling of unlisted Vimeo videos #2986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've reported the issue upstream as well: ampproject/amphtml#23804 |
swissspidy
reviewed
Aug 9, 2019
swissspidy
approved these changes
Aug 12, 2019
westonruter
added a commit
that referenced
this pull request
Aug 12, 2019
…p-bind-syntax * 'develop' of github.com:ampproject/amp-wp: RTLCSS all the things (#2977) Fix AMP Story editor compatibility with code editor (#3007) Update dependency core-js to v3.2.1 (#3011) Update amphtml validator spec to v1907301630320 (#3003) Improve handling of unlisted Vimeo videos (#2986) Always hide AMP admin menu item and compatibility tool menu ite… (#3005) Update dependency dom-scroll-into-view to v2.0.1 (#3008) Hide tooltips that should be hidden (#2988)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vimeo has the ability to create unlisted videos: https://vimeo.com/blog/post/share-unlisted-videos-with-private-links/
Such videos have URLs like:
https://vimeo.com/172355597/abcdef0123The AMP plugin was erroneously turning this into the following:
And this was causing an AMP validation error, because the video ID has to consist of digits only. But here the secret video key was erroneously being provided as the ID.
Now, it's likely that this will still result in the Vimeo unlisted video being unviewable, since the unlisted key is just dropped. Nevertheless, it's somewhat better than having an AMP validation error.